From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [libnftables PATCH 1/3] tests: fix error reporting
Date: Tue, 1 Oct 2013 11:45:38 +0200 [thread overview]
Message-ID: <20131001094538.GB7573@localhost> (raw)
In-Reply-To: <CAOkSjBjFsqZSSaNr6jUMN3aZR=fA+TR2dBSVNyOp_xLGt84DvQ@mail.gmail.com>
On Tue, Oct 01, 2013 at 12:02:15AM +0200, Arturo Borrero Gonzalez wrote:
> On 30 September 2013 19:41, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Sep 30, 2013 at 05:05:52PM +0200, Arturo Borrero Gonzalez wrote:
> >> The testbench was not reporting errors properly.
> >>
> >> With this patch, "1" is returned to the shell if the test failed (instead of
> >> returning "0" unconditionally). Textual reporting is also fixed.
> >
> > How is it broken?
> >
> > IIRC the error reporting provides some rudimentary cursor to indicate
> > where the problem happens. I think this patch breaks it.
>
> I don't see where the break happens. Could you give me some hints?
>
> For me, the cursor works as expected.
This patch includes changes for different things, please split it in
chunks including the corresponding description. Thanks.
prev parent reply other threads:[~2013-10-01 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 15:05 [libnftables PATCH 1/3] tests: fix error reporting Arturo Borrero Gonzalez
2013-09-30 15:05 ` [libnftables PATCH 2/3] table: json: fix json style Arturo Borrero Gonzalez
2013-09-30 17:43 ` Pablo Neira Ayuso
2013-09-30 18:06 ` Stephen Hemminger
2013-09-30 18:34 ` Pablo Neira Ayuso
2013-09-30 21:55 ` Arturo Borrero Gonzalez
2013-10-01 9:43 ` Pablo Neira Ayuso
2013-09-30 15:06 ` [libnftables PATCH 3/3] src: add low-level ruleset API Arturo Borrero Gonzalez
2013-09-30 17:46 ` Pablo Neira Ayuso
2013-09-30 17:41 ` [libnftables PATCH 1/3] tests: fix error reporting Pablo Neira Ayuso
2013-09-30 22:02 ` Arturo Borrero Gonzalez
2013-10-01 9:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001094538.GB7573@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.