All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Holger Eitzenberger <holger@eitzenberger.org>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/1] sip: introduce nf_nat_sip_hooks
Date: Tue, 1 Oct 2013 12:34:48 +0200	[thread overview]
Message-ID: <20131001103448.GA6725@localhost> (raw)
In-Reply-To: <20130930151014.641823929@eitzenberger.org>

On Mon, Sep 30, 2013 at 05:07:28PM +0200, Holger Eitzenberger wrote:
> There are currently seven different NAT hooks used in both
> nf_conntrack_sip and nf_nat_sip, each of the hooks is exported in
> nf_conntrack_sip, then set from the nf_nat_sip NAT helper.
> 
> And because each of them is exported there is quite some overhead
> introduced due of this.
> 
> By introducing nf_nat_sip_hooks I am able to reduce both text/data
> somewhat.  For nf_conntrack_sip e. g. I get
> 
>         text             data              bss              dec
> old    15243             5256               32            20531
> new    15010             5192               32            20234

Applied, thanks Holger!

      reply	other threads:[~2013-10-01 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 15:07 [PATCH v2 net-next 0/1] sip: introduce nf_nat_sip_hooks Holger Eitzenberger
2013-09-30 15:07 ` [PATCH v2 net-next 1/1] " Holger Eitzenberger
2013-10-01 10:34   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131001103448.GA6725@localhost \
    --to=pablo@netfilter.org \
    --cc=holger@eitzenberger.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.