Re: pynfs updates

["'Bruce Fields'" <bfields@fieldses.org>]

On Mon, Sep 30, 2013 at 07:54:52PM -0400, Frank Filz wrote:
> > 	- "Add two SECINFO_NO_NAME tests for
> > SECINFO_STYLE4_PARENT":
> > 		- SECNN3: is / required to have no parent?  (I'd assumed
> > 		  here that it would also be OK to follow the convention
> > 		  that / is its own parent, but I'll admit to not having
> > 		  thought about this much.)
> 
> >From LOOKUPP:
> 
> 18.14.3. DESCRIPTION
> The current filehandle is assumed to refer to a regular directory or
> a named attribute directory. LOOKUPP assigns the filehandle for its
> parent directory to be the current filehandle. If there is no parent
> directory, an NFS4ERR_NOENT error must be returned. Therefore,
> NFS4ERR_NOENT will be returned by the server when the current
> filehandle is at the root or top of the server's file tree.

OK, fine.

> > 		- SECNN4: is env.home necessarily unequal to "/"?  Would
> > 		  seem better to do the lookup in a subdirectory just to
> > 		  be certain.
> 
> Env.home is the directory you specify on the command line, I think the
> presumption is that it is a writeable file system. Pynfs creates tmp and
> tree directories in home (and maybe some files also?). Guess if / was
> writeable, you could specify /, so yea, maybe it should go into tmp.

Sounds good.

> 
> A better test might actually be to do LOOKUP down to home and even into tmp,
> looking for a junction, and then do the SECINFO_NO_NAME(parent) on the
> directory handle just across the junction if one was found.

Yeah it'd be nice to check that cross-filesystem case but I don't think
it's necessary (and you still have to deal with the case where a
mountpoint's not found).

If tests at mountpoints were useful perhaps we could pass in a
mountpoint on the commandline.  Or add some sort of export-configuration
interface to the serverhelper script and let pynfs setup exports itself.

--b.