All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7779: split r8a7779_init_irq_extpin() for DT
Date: Wed, 02 Oct 2013 08:05:20 +0000	[thread overview]
Message-ID: <20131002080518.GC28462@verge.net.au> (raw)
In-Reply-To: <87r4c4yz2k.wl%kuninori.morimoto.gx@renesas.com>

On Tue, Oct 01, 2013 at 11:19:35PM -0700, Kuninori Morimoto wrote:
> r8a7779 INTC needs IRL pin mode settings to determine
> behavior of IRQ0 - IRQ3, and r8a7779_init_irq_extpin()
> is controlling it via irlm parameter.
> But this function registers renesas_intc_irqpin driver
> if irlm was set, and this value depends on platform.
> This is not good for DT.
> This patch splits r8a7779_init_irq_extpin() function
> into "mode settings" and "funtion register" parts,
> and add status = "disabled" on r8a7779.dtsi as default
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  arch/arm/boot/dts/r8a7779.dtsi                |    1 +
>  arch/arm/mach-shmobile/include/mach/r8a7779.h |    1 +
>  arch/arm/mach-shmobile/setup-r8a7779.c        |    6 +++++-
>  3 files changed, 7 insertions(+), 1 deletion(-)

Please split this into two patches.

1. A DT patch that modifies r8a7779.dtsi
2. An SoC patch that modifies r8a7779.h and setup-r8a7779.c

  reply	other threads:[~2013-10-02  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02  6:19 [PATCH 1/2] ARM: shmobile: r8a7779: split r8a7779_init_irq_extpin() for DT Kuninori Morimoto
2013-10-02  8:05 ` Simon Horman [this message]
2013-10-02  8:07 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002080518.GC28462@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.