All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] clk: sunxi: mod0 support
Date: Wed, 2 Oct 2013 16:38:25 +0200	[thread overview]
Message-ID: <20131002143825.GA32149@lukather> (raw)
In-Reply-To: <524A0B4A.8080902@elopez.com.ar>

Hi Emilio

On Mon, Sep 30, 2013 at 08:37:46PM -0300, Emilio L?pez wrote:
> >>+static const struct factors_data sun4i_mod0_data __initconst = {
> >>+	.enable = 31,
> >>+	.mux = 24,
> >>+	.table = &sun4i_mod0_config,
> >>+	.getter = sun4i_get_mod0_factors,
> >>+};
> >
> >How are the parents handled here for the mux part? Do you expect the
> >different parents in a precise order in the device tree, so that you
> >have a direct mapping to the value to put in the muxing registers, or do
> >you have a smarter way to do it?
> 
> Indeed, the parents must be indicated on the DT using the same order
> as on the register. In other words, it works the same as all the
> other muxes we have implemented so far. The clock corresponding to
> bits 00 goes first, then the one corresponding to 01, etc.

Ok. It should be documented in the bindings doc then.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131002/0d81db3f/attachment.sig>

  reply	other threads:[~2013-10-02 14:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29  3:49 [PATCH 00/10] clk: sunxi: PLL4/5/6, mod0 and mbus support Emilio López
2013-09-29  3:49 ` [PATCH 01/10] clk: sunxi: register factors clocks behind composite Emilio López
2013-09-30 17:03   ` Maxime Ripard
2013-09-29  3:49 ` [PATCH 02/10] clk: sunxi: add gating support to PLL1 Emilio López
2013-09-30 17:05   ` Maxime Ripard
2013-09-29  3:49 ` [PATCH 03/10] ARM: sunxi: add PLL4 support Emilio López
2013-09-29  3:49 ` [PATCH 04/10] clk: sunxi: add PLL5 and PLL6 support Emilio López
2013-09-30 17:21   ` Maxime Ripard
2013-09-30 23:29     ` Emilio López
2013-10-03 10:32       ` Maxime Ripard
2013-09-29  3:49 ` [PATCH 05/10] ARM: " Emilio López
2013-09-29  3:49 ` [PATCH 06/10] clk: sunxi: mod0 support Emilio López
2013-09-30 17:35   ` Maxime Ripard
2013-09-30 23:37     ` Emilio López
2013-10-02 14:38       ` Maxime Ripard [this message]
2013-09-29  3:49 ` [PATCH 07/10] ARM: sun4i: dt: mod0 clocks Emilio López
2013-09-29  3:49 ` [PATCH 08/10] ARM: sun5i: " Emilio López
2013-09-29  3:49 ` [PATCH 09/10] ARM: sun7i: " Emilio López
2013-09-29  3:49 ` [PATCH 10/10] ARM: sunxi: dt: add nodes for the mbus clock Emilio López
2013-09-30 17:38 ` [PATCH 00/10] clk: sunxi: PLL4/5/6, mod0 and mbus support Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002143825.GA32149@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.