From: Marek Vasut <marex@denx.de>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
b32955@freescale.com, fabio.estevam@freescale.com,
shawn.guo@linaro.org, jslaby@suse.cz
Subject: Re: [PATCH v2 0/2] serial: mxs-auart: wait for DMA buffer to flush before shutdown
Date: Wed, 2 Oct 2013 15:30:22 +0200 [thread overview]
Message-ID: <201310021530.22317.marex@denx.de> (raw)
In-Reply-To: <1380715364-8025-1-git-send-email-hector.palacios@digi.com>
Dear Hector Palacios,
> This fixes a bug whereby the AUART was shutdown while bytes
> were still waiting in the DMA buffer to be transmistted.
>
> Changes since v1:
> * Split the patch in two: one to set the fifosize to the
> DMA buffer size, and another to wait for the FIFO to empty
> before disabling the AUART.
> * The wait for the fifo to empty is now independent of DMA
> being enabled.
> * Fix bug on readl() call
> * Remove bad URL in commit log
>
> Hector Palacios (2):
> serial: mxs-auart: set the FIFO size to DMA buffer size
> serial: mxs-auart: wait for FIFO to flush before shutdown
>
> drivers/tty/serial/mxs-auart.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
Looks OK
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] serial: mxs-auart: wait for DMA buffer to flush before shutdown
Date: Wed, 2 Oct 2013 15:30:22 +0200 [thread overview]
Message-ID: <201310021530.22317.marex@denx.de> (raw)
In-Reply-To: <1380715364-8025-1-git-send-email-hector.palacios@digi.com>
Dear Hector Palacios,
> This fixes a bug whereby the AUART was shutdown while bytes
> were still waiting in the DMA buffer to be transmistted.
>
> Changes since v1:
> * Split the patch in two: one to set the fifosize to the
> DMA buffer size, and another to wait for the FIFO to empty
> before disabling the AUART.
> * The wait for the fifo to empty is now independent of DMA
> being enabled.
> * Fix bug on readl() call
> * Remove bad URL in commit log
>
> Hector Palacios (2):
> serial: mxs-auart: set the FIFO size to DMA buffer size
> serial: mxs-auart: wait for FIFO to flush before shutdown
>
> drivers/tty/serial/mxs-auart.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
Looks OK
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-02 13:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 12:02 [PATCH v2 0/2] serial: mxs-auart: wait for DMA buffer to flush before shutdown Hector Palacios
2013-10-02 12:02 ` Hector Palacios
2013-10-02 12:02 ` [PATCH v2 1/2] serial: mxs-auart: set the FIFO size to DMA buffer size Hector Palacios
2013-10-02 12:02 ` Hector Palacios
2013-10-02 12:25 ` Uwe Kleine-König
2013-10-02 12:25 ` Uwe Kleine-König
2013-10-02 12:02 ` [PATCH v2 2/2] serial: mxs-auart: wait for FIFO to flush before shutdown Hector Palacios
2013-10-02 12:02 ` Hector Palacios
2013-10-02 12:22 ` Uwe Kleine-König
2013-10-02 12:22 ` Uwe Kleine-König
2013-10-02 14:01 ` Hector Palacios
2013-10-02 14:01 ` Hector Palacios
2013-10-02 20:18 ` Uwe Kleine-König
2013-10-02 20:18 ` Uwe Kleine-König
2013-10-02 13:30 ` Marek Vasut [this message]
2013-10-02 13:30 ` [PATCH v2 0/2] serial: mxs-auart: wait for DMA buffer " Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310021530.22317.marex@denx.de \
--to=marex@denx.de \
--cc=b32955@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=hector.palacios@digi.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.