From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Fix syscall32 to supply 6th arg to syscal
Date: Wed, 2 Oct 2013 14:15:37 -0400 [thread overview]
Message-ID: <20131002181537.GA30862@redhat.com> (raw)
In-Reply-To: <CAEGbLtuTi3BZffyGLahgGDVp2YhqWMPwY6VLUOBdnfnVzZDeQQ@mail.gmail.com>
On Wed, Oct 02, 2013 at 11:12:21AM -0700, Ildar Muslukhov wrote:
> I finally was able to reproduce that bug. In order to validate the
> assumption that the "syscall32 fix" patch introduced that bug I pulled
> the latest trinity source and removed the patch at question from the
> source (gladly patch was small). And I am still getting segfault.
> Thus, assumption that this patch introduced that bug looks less
> probable now. Furthermore, if you run trinity with a single 32 bit
> function (-c perf_event_open,32 for example) it runs just fine.
>
> Several observations from my runs:
> 1) Not all 32 bit calls end up in segfault.
> 2) All segfaults are calls to 32 bit syscall.
>
> Still digging into what causes this, will keep you posted.
This may have been why I had this..
// FIXME: I forgot why this got disabled. Revisit.
// if (rand() % 100 < 10)
// shm->do32bit[childno] = TRUE;
in choose_syscall_table.
Probably an old bug that I've never found time to dig into.
Dave
next prev parent reply other threads:[~2013-10-02 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:24 [PATCH] Fix syscall32 to supply 6th arg to syscal Ildar Muslukhov
2013-09-19 21:35 ` Dave Jones
2013-10-02 15:12 ` Dave Jones
2013-10-02 16:14 ` Ildar Muslukhov
2013-10-02 16:43 ` Dave Jones
2013-10-02 18:12 ` Ildar Muslukhov
2013-10-02 18:15 ` Dave Jones [this message]
2013-10-02 20:44 ` Ildar Muslukhov
2013-10-02 20:48 ` Dave Jones
2013-10-02 20:53 ` Ildar Muslukhov
2013-10-02 20:57 ` Dave Jones
2013-10-02 21:03 ` Ildar Muslukhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002181537.GA30862@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.