From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Date: Wed, 2 Oct 2013 17:48:05 -0700 Message-ID: <20131003004805.GL6768@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net To: Alexander Gordeev Cc: linux-mips@linux-mips.org, "VMware, Inc." , Benjamin Herrenschmidt , linux-nvme@lists.infradead.org, linux-ide@vger.kernel.org, stable@vger.kernel.org, linux-s390@vger.kernel.org, Andy King , linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Ingo Molnar , linux-pci@vger.kernel.org, Matt Porter , iss_storagedev@hp.com, linux-driver@qlogic.com, Michael Ellerman , Tejun Heo , Bjorn Helgaas , Dan Williams , Solarflare linux maintainers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , e1000-devel@lists.sourceforge.net, Martin Schwidefsky , linux390@de.ibm.c List-Id: linux-ide@vger.kernel.org On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > /* On SNB, the link interrupt is always tied to 4th vector. If > * we can't get all 4, then we can't use MSI-X. > */ > - if (ndev->hw_type != BWD_HW) { > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { Nack, this check is unnecessary. Also, no comment in the commit on why it could be necessary. > rc = -EIO; > goto err1; > } > -- > 1.7.7.6 > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 03 Oct 2013 02:48:18 +0200 (CEST) Received: from mga11.intel.com ([192.55.52.93]:30010 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6868565Ab3JCAsPXEe03 (ORCPT ); Thu, 3 Oct 2013 02:48:15 +0200 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 Oct 2013 17:48:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,1022,1371106800"; d="scan'208";a="410690805" Received: from jonmason-lab.ch.intel.com (HELO jonmason-lab) ([143.182.51.14]) by fmsmga002.fm.intel.com with ESMTP; 02 Oct 2013 17:48:06 -0700 Date: Wed, 2 Oct 2013 17:48:05 -0700 From: Jon Mason To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Ralf Baechle , Michael Ellerman , Benjamin Herrenschmidt , Martin Schwidefsky , Ingo Molnar , Tejun Heo , Dan Williams , Andy King , Matt Porter , stable@vger.kernel.org, linux-pci@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux390@de.ibm.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-ide@vger.kernel.org, iss_storagedev@hp.com, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-driver@qlogic.com, Solarflare linux maintainers , "VMware, Inc." , linux-scsi@vger.kernel.org Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Message-ID: <20131003004805.GL6768@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38174 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: jon.mason@intel.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > /* On SNB, the link interrupt is always tied to 4th vector. If > * we can't get all 4, then we can't use MSI-X. > */ > - if (ndev->hw_type != BWD_HW) { > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { Nack, this check is unnecessary. Also, no comment in the commit on why it could be necessary. > rc = -EIO; > goto err1; > } > -- > 1.7.7.6 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon.mason@intel.com (Jon Mason) Date: Wed, 2 Oct 2013 17:48:05 -0700 Subject: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt In-Reply-To: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> Message-ID: <20131003004805.GL6768@jonmason-lab> On Wed, Oct 02, 2013@12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > /* On SNB, the link interrupt is always tied to 4th vector. If > * we can't get all 4, then we can't use MSI-X. > */ > - if (ndev->hw_type != BWD_HW) { > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { Nack, this check is unnecessary. Also, no comment in the commit on why it could be necessary. > rc = -EIO; > goto err1; > } > -- > 1.7.7.6 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ozlabs.org (Postfix) with ESMTP id 66A872C00BB for ; Thu, 3 Oct 2013 10:48:08 +1000 (EST) Date: Wed, 2 Oct 2013 17:48:05 -0700 From: Jon Mason To: Alexander Gordeev Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Message-ID: <20131003004805.GL6768@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> Cc: linux-mips@linux-mips.org, "VMware, Inc." , linux-nvme@lists.infradead.org, linux-ide@vger.kernel.org, stable@vger.kernel.org, linux-s390@vger.kernel.org, Andy King , linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Ingo Molnar , linux-pci@vger.kernel.org, iss_storagedev@hp.com, linux-driver@qlogic.com, Tejun Heo , Bjorn Helgaas , Dan Williams , Solarflare linux maintainers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , e1000-devel@lists.sourceforge.net, Martin Schwidefsky , linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev > --- > drivers/ntb/ntb_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index de2062c..eccd5e5 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > /* On SNB, the link interrupt is always tied to 4th vector. If > * we can't get all 4, then we can't use MSI-X. > */ > - if (ndev->hw_type != BWD_HW) { > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { Nack, this check is unnecessary. Also, no comment in the commit on why it could be necessary. > rc = -EIO; > goto err1; > } > -- > 1.7.7.6 >