From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Thu, 03 Oct 2013 04:14:15 +0000 Subject: Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Message-Id: <20131003041415.GA2801@iris.ozlabs.ibm.com> List-Id: References: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Aneesh Kumar K.V" Cc: agraf@suse.de, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b It's a good idea to give the headline of the commit as well as the ID. I also like to trim the ID to 10 characters or so. So it should look like this: This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate kvm_vcpu structs from kvm_vcpu_cache"). > arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': > arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' > make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 > > Signed-off-by: Aneesh Kumar K.V Acked-by: Paul Mackerras Paul. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 3 Oct 2013 14:14:15 +1000 From: Paul Mackerras To: "Aneesh Kumar K.V" Subject: Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Message-ID: <20131003041415.GA2801@iris.ozlabs.ibm.com> References: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org, agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b It's a good idea to give the headline of the commit as well as the ID. I also like to trim the ID to 10 characters or so. So it should look like this: This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate kvm_vcpu structs from kvm_vcpu_cache"). > arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': > arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' > make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 > > Signed-off-by: Aneesh Kumar K.V Acked-by: Paul Mackerras Paul. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Date: Thu, 3 Oct 2013 14:14:15 +1000 Message-ID: <20131003041415.GA2801@iris.ozlabs.ibm.com> References: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: agraf@suse.de, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from ozlabs.org ([203.10.76.45]:49014 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374Ab3JCEOY (ORCPT ); Thu, 3 Oct 2013 00:14:24 -0400 Content-Disposition: inline In-Reply-To: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b It's a good idea to give the headline of the commit as well as the ID. I also like to trim the ID to 10 characters or so. So it should look like this: This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate kvm_vcpu structs from kvm_vcpu_cache"). > arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create': > arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu' > make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1 > > Signed-off-by: Aneesh Kumar K.V Acked-by: Paul Mackerras Paul.