From: Greg KH <gregkh@linuxfoundation.org>
To: Kamlakant Patel <kamlakant.patel@broadcom.com>
Cc: devel@driverdev.osuosl.org, linux-mtd@lists.infradead.org,
manonuevo@micron.com
Subject: Re: [PATCH] Staging: MTD: Micron SPINAND Driver support
Date: Wed, 2 Oct 2013 22:25:51 -0700 [thread overview]
Message-ID: <20131003052551.GD1312@kroah.com> (raw)
In-Reply-To: <1380620038-25643-1-git-send-email-kamlakant.patel@broadcom.com>
On Tue, Oct 01, 2013 at 03:03:58PM +0530, Kamlakant Patel wrote:
>
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/mt29f_spinand/Kconfig | 16 +
> drivers/staging/mt29f_spinand/Makefile | 1 +
> drivers/staging/mt29f_spinand/TODO | 13 +
> drivers/staging/mt29f_spinand/mt29f_spinand.c | 962 ++++++++++++++++++++++++++
> drivers/staging/mt29f_spinand/mt29f_spinand.h | 107 +++
Why do you need a separate .h file for a single driver?
It's not a reason to reject this, just curious if it's that way for a
reason. I'll look at this closer tomorrow and apply it if it passes my
minor amount of build testing.
thanks,
greg k-h
prev parent reply other threads:[~2013-10-03 5:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 13:22 [PATCH] Staging: MTD: Micron SPINAND Driver support Kamlakant Patel
2013-09-25 23:14 ` Greg KH
2013-09-25 23:15 ` Greg KH
2013-10-01 7:26 ` Kamlakant Patel
2013-10-01 9:33 ` Kamlakant Patel
2013-10-02 18:45 ` Brian Norris
2013-10-03 5:49 ` Gupta, Pekon
2013-10-03 9:54 ` Kamlakant Patel
2013-10-03 5:24 ` Greg KH
2013-10-03 5:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003052551.GD1312@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=kamlakant.patel@broadcom.com \
--cc=linux-mtd@lists.infradead.org \
--cc=manonuevo@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.