From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [iptables-nftables PATCH 0/3] NFPROTO_ARP and arp mangle target support (+ one minor fix)
Date: Thu, 3 Oct 2013 11:23:59 +0200 [thread overview]
Message-ID: <20131003092359.GA14246@localhost> (raw)
In-Reply-To: <524D2A2B.1010507@linux.intel.com>
On Thu, Oct 03, 2013 at 11:26:19AM +0300, Tomasz Bursztyka wrote:
> Hi,
>
> @Pablo: I understand that patch 2 is not necessary, but what about
> patch 3? This one is relevant to get xtables-arp being able to
> handle mangle target.
> Or is there any issue with it?
Please, rename it to libxt_mangle.c and restrict its usage to the
NFPROTO_ARP family. With this change, I think we can skip patch 2, I'm
reticent to bloat our build system to support libarp_ prefix, it's
just one single extension after all.
Let me know if you have any issue, thanks.
> >This patchset prepares for arptables-nftables to be included so it will use libxtables for its target.
> >
> >Tomasz Bursztyka (3):
> > nft: Fix a minor compilation warning
> > libxtables: Add NFPROTO_ARP support for libarpt_* prefixed extensions
> > libxtables: Port libarptc mangle target into libxtables
> >
> > configure.ac | 5 +
> > extensions/GNUmakefile.in | 52 +++-
> > extensions/libarpt_mangle.c | 388 ++++++++++++++++++++++++++++++
> > include/linux/netfilter_arp.h | 19 ++
> > include/linux/netfilter_arp/arp_tables.h | 204 ++++++++++++++++
> > include/linux/netfilter_arp/arpt_mangle.h | 26 ++
> > iptables/nft-shared.c | 2 +-
> > libxtables/xtables.c | 14 ++
> > 8 files changed, 701 insertions(+), 9 deletions(-)
> > create mode 100644 extensions/libarpt_mangle.c
> > create mode 100644 include/linux/netfilter_arp.h
> > create mode 100644 include/linux/netfilter_arp/arp_tables.h
> > create mode 100644 include/linux/netfilter_arp/arpt_mangle.h
> >
>
next prev parent reply other threads:[~2013-10-03 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 7:51 [iptables-nftables PATCH 0/3] NFPROTO_ARP and arp mangle target support (+ one minor fix) Tomasz Bursztyka
2013-09-06 7:51 ` [iptables-nftables PATCH 1/3] nft: Fix a minor compilation warning Tomasz Bursztyka
2013-09-06 7:51 ` [iptables-nftables PATCH 2/3] libxtables: Add NFPROTO_ARP support for libarpt_* prefixed extensions Tomasz Bursztyka
2013-09-06 7:51 ` [iptables-nftables PATCH 3/3] libxtables: Port libarptc mangle target into libxtables Tomasz Bursztyka
2013-10-03 8:26 ` [iptables-nftables PATCH 0/3] NFPROTO_ARP and arp mangle target support (+ one minor fix) Tomasz Bursztyka
2013-10-03 9:23 ` Pablo Neira Ayuso [this message]
2013-10-03 9:31 ` Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003092359.GA14246@localhost \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tomasz.bursztyka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.