All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset
Date: Thu, 3 Oct 2013 16:54:04 +0300	[thread overview]
Message-ID: <20131003135404.GA1267@redhat.com> (raw)
In-Reply-To: <1380807975-13266-1-git-send-email-pbonzini@redhat.com>

On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote:
> PCI is handling resetting of its devices before the bus is reset,
> but this is only necessary because qdev is broken and usually does
> pre-order reset.  Post-order is a much better definition.  Drop
> the unnecessary flexibility that lets bus decide the reset order,
> convert to post-order, and make PCI use common code for reset.

Need to go carefully here. I remember a bunch of targets
were relying on reset in this order, though don't
have the detail right now.

What kind of testing did this patchset go through?

> Paolo Bonzini (4):
>   pci: do not export pci_bus_reset
>   pci: clean up resetting of IRQs
>   qdev: allow both pre- and post-order vists in qdev walking functions
>   qdev: switch reset to post-order
> 
>  hw/core/qdev.c         |   47 ++++++++++++++++++++++++++++++++++-------------
>  hw/pci/pci.c           |   42 ++++++++++++++++++++----------------------
>  hw/pci/pci_bridge.c    |    2 +-
>  include/hw/pci/pci.h   |    1 -
>  include/hw/qdev-core.h |   15 ++++++++++-----
>  5 files changed, 65 insertions(+), 42 deletions(-)

  parent reply	other threads:[~2013-10-03 13:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 13:46 [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 1/4] pci: do not export pci_bus_reset Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order Paolo Bonzini
2013-10-03 13:54 ` Michael S. Tsirkin [this message]
2013-10-03 15:58   ` [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset Paolo Bonzini
2013-10-03 16:54     ` Michael S. Tsirkin
2013-10-03 16:53       ` Paolo Bonzini
2013-10-06 18:28         ` Michael S. Tsirkin
2013-10-06 20:34           ` Paolo Bonzini
2013-10-09 16:10             ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2013-12-06 16:54 Paolo Bonzini
2013-12-19 19:15 ` Michael S. Tsirkin
2013-12-19 23:45   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131003135404.GA1267@redhat.com \
    --to=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.