From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [RFC PATCH] regulator: core: Add ability to create a lookup alias for supply
Date: Thu, 3 Oct 2013 17:11:14 +0100 [thread overview]
Message-ID: <20131003161114.GA3635@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20131002195029.GH27287@sirena.org.uk>
On Wed, Oct 02, 2013 at 08:50:29PM +0100, Mark Brown wrote:
> Bulk versions of the API would also make sense - it's likely that more
> than one supply will need to be mapped - and please also add managed
> versions so people don't have to write cleanup code.
For the bulk API would you prefer taking a single src and alias
device and a list of supplies, or lists for all three?
I would go for a list just for the supplies, as lists of devices
would probably need to be filled in by a loop on the user end
anyway negating the point of the bulk API some what and a lot of
the use-cases will like have the same device on both sides for
all the supplies.
> > I have a couple of patches that update the Arizona driver to
> > use this that I will send in if you think this looks along
> > the lines of what you were suggesting.
>
> This seems like someting that should be in the MFD core, or at least
> that there should be helpers in the core. Something like a set of
> mappings in the mfd_cell so it's all data to the drivers.
Looks like a simple enough addition to the MFD core, I will
submit a patch doing it this way and see where we get to.
> Please use a more meaningful name for dev. It might also be worth
> allowing rewriting of the supply name since we'll probably find other
> applications for things like modular board designs where name rewriting
> is useful; since it's a function call with a parameter list it's harder
> to add later than it would be with a struct.
Seems that it could be useful to change the supply name, I will
add this in as well.
Thanks,
Charles
next prev parent reply other threads:[~2013-10-03 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 12:16 [RFC PATCH] regulator: core: Add ability to create a lookup alias for supply Charles Keepax
2013-10-02 19:50 ` Mark Brown
2013-10-03 16:11 ` Charles Keepax [this message]
2013-10-03 16:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003161114.GA3635@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.