From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH 0/2] Add support for Qualcomm's PRNG Date: Thu, 3 Oct 2013 12:51:30 -0400 Message-ID: <20131003165130.GA11974@thunk.org> References: <1380811955-18085-1-git-send-email-svarbanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1380811955-18085-1-git-send-email-svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stanimir Varbanov Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Matt Mackall , Herbert Xu , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Landley , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Thu, Oct 03, 2013 at 05:52:33PM +0300, Stanimir Varbanov wrote: > This patch set adds hardware RNG driver wich is used to control the > Qualcomm's PRNG hardware block. > The first patch document the DT bindings needed to sucessfuly probe > the driver and the second patch adds the driver. Is this really a PRNG (pseudo-random number generator)? What are the guarantees which Qualcomm is providing for the PRNG? If it's really a PRNG such as AES(i++, NSA_KEY), then kudo to Qualcomm for being honest. If it is supposed to be (or at least claimed to be) a secure random number generator ala RDRAND suitable for use in cryptographic applications, calling it a PRNG is going to be a bit misleading. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754702Ab3JCQvv (ORCPT ); Thu, 3 Oct 2013 12:51:51 -0400 Received: from imap.thunk.org ([74.207.234.97]:41742 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754576Ab3JCQvt (ORCPT ); Thu, 3 Oct 2013 12:51:49 -0400 Date: Thu, 3 Oct 2013 12:51:30 -0400 From: "Theodore Ts'o" To: Stanimir Varbanov Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Matt Mackall , Herbert Xu , linux-kernel@vger.kernel.org, Rob Landley , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 0/2] Add support for Qualcomm's PRNG Message-ID: <20131003165130.GA11974@thunk.org> Mail-Followup-To: Theodore Ts'o , Stanimir Varbanov , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Matt Mackall , Herbert Xu , linux-kernel@vger.kernel.org, Rob Landley , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org References: <1380811955-18085-1-git-send-email-svarbanov@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380811955-18085-1-git-send-email-svarbanov@mm-sol.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 03, 2013 at 05:52:33PM +0300, Stanimir Varbanov wrote: > This patch set adds hardware RNG driver wich is used to control the > Qualcomm's PRNG hardware block. > The first patch document the DT bindings needed to sucessfuly probe > the driver and the second patch adds the driver. Is this really a PRNG (pseudo-random number generator)? What are the guarantees which Qualcomm is providing for the PRNG? If it's really a PRNG such as AES(i++, NSA_KEY), then kudo to Qualcomm for being honest. If it is supposed to be (or at least claimed to be) a secure random number generator ala RDRAND suitable for use in cryptographic applications, calling it a PRNG is going to be a bit misleading. Cheers, - Ted