From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: Fix error handling in musb_hcd.c
Date: Thu, 3 Oct 2013 17:56:09 +0200 [thread overview]
Message-ID: <201310031756.09324.marex@denx.de> (raw)
In-Reply-To: <1380639536-2554-1-git-send-email-amurray@embedded-bits.co.uk>
Dear Andrew Murray,
> The wait_until_[rx|tx]ep_ready functions return a u8 to indicate success
> containing the value 0, 1 or -1. This patch changes the return type to an
> int to accommodate the negative return values.
>
> These functions are used in the file using calls such as if (!wait_until...
> Where a -1 is returned it is mishandled and treated as success instead of
> a CRC error. This patch addresses this.
>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Andrew Murray <amurray@embedded-bits.co.uk>
Acked-by: Marek Vasut <marex@denx.de>
Tom, feel free to pick this up if it's ok on this omap hardware.
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-10-03 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 14:58 [U-Boot] [PATCH] usb: Fix error handling in musb_hcd.c Andrew Murray
2013-10-03 15:56 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310031756.09324.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.