All of lore.kernel.org
 help / color / mirror / Atom feed
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support
Date: Thu, 3 Oct 2013 23:27:51 +0300	[thread overview]
Message-ID: <20131003202751.GZ6192@mwanda> (raw)
In-Reply-To: <1380826287-30253-1-git-send-email-fabio.estevam@freescale.com>

On Thu, Oct 03, 2013 at 03:51:25PM -0300, Fabio Estevam wrote:
> This is based on the initial work done by Sascha Hauer and Tony Prisk.
> 
> Tested on imx6q-wandboard and imx6q-sabresd boards.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Rebased against 3.12-rc3 and fixed header file location
> 

It should be done against linux-next as previously mentioned but the
header still needs to be fixed in linux-next I think?

Also it has the following Smatch warnings which are all basically
correct.

drivers/staging/imx-drm/imx-hdmi.c:511 imx_hdmi_update_csc_coeffs() error: buffer overflow '(*csc_coeff)[0]' 4 <= 4
drivers/staging/imx-drm/imx-hdmi.c:520 imx_hdmi_update_csc_coeffs() error: buffer overflow '(*csc_coeff)[1]' 4 <= 4
drivers/staging/imx-drm/imx-hdmi.c:529 imx_hdmi_update_csc_coeffs() error: buffer overflow '(*csc_coeff)[2]' 4 <= 4
drivers/staging/imx-drm/imx-hdmi.c:785 hdmi_phy_i2c_write() info: ignoring unreachable code.
drivers/staging/imx-drm/imx-hdmi.c:873 hdmi_phy_configure() warn: unsigned 'hdmi->hdmi_data.video_mode.mpixelclock' is never less than zero.
drivers/staging/imx-drm/imx-hdmi.c:1537 imx_hdmi_fb_registered() warn: inconsistent returns spin_lock:&hdmi->irq_lock: locked (1514 [s32min-(-1),1-s32max]) unlocked (1508 [0], 1537 [0])
drivers/staging/imx-drm/imx-hdmi.c:1537 imx_hdmi_fb_registered() warn: inconsistent returns irqsave:flags: locked (1514 [s32min-(-1),1-s32max]) unlocked (1508 [0], 1537 [0])
drivers/staging/imx-drm/imx-hdmi.c:1837 imx_hdmi_platform_probe() info: why not propagate 'irq' from platform_get_irq() instead of (-22)?

regards,
dan carpenter

  parent reply	other threads:[~2013-10-03 20:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1380826287-30253-1-git-send-email-fabio.estevam@freescale.com>
2013-10-03 18:51 ` [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support Fabio Estevam
2013-10-14 17:38   ` Russell King - ARM Linux
2013-10-15  2:47     ` Fabio Estevam
2013-10-15 10:00       ` Russell King - ARM Linux
2013-10-15 10:09         ` Sascha Hauer
2013-10-14 17:40   ` Russell King - ARM Linux
2013-10-14 22:50     ` Russell King - ARM Linux
2013-10-15  3:20       ` Fabio Estevam
2013-10-15  7:46       ` Sascha Hauer
2013-10-15  9:18         ` Russell King - ARM Linux
2013-10-15 10:35           ` Russell King - ARM Linux
2013-10-16  7:20             ` Sascha Hauer
2013-10-03 18:51 ` [PATCH v2 3/3] ARM: dts: imx6qdl-sabresd: " Fabio Estevam
2013-10-03 20:27 ` Dan Carpenter [this message]
2013-10-15 13:10   ` [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support Russell King - ARM Linux
2013-10-15 13:17     ` Fabio Estevam
2013-10-16 17:03       ` Russell King - ARM Linux
2013-10-16 18:07         ` Russell King - ARM Linux
2013-10-16 18:31           ` Greg Kroah-Hartman
2013-10-16 19:02             ` Russell King - ARM Linux
2013-10-16 21:20               ` Sascha Hauer
2013-10-17  8:27               ` Lucas Stach
2013-10-20  0:04             ` Russell King - ARM Linux
2013-10-20 13:00               ` Russell King - ARM Linux
2013-10-20 16:31                 ` Russell King - ARM Linux
2013-10-20 21:56                   ` Russell King - ARM Linux
2013-10-20  9:32             ` Russell King - ARM Linux
2013-10-16 19:37         ` Troy Kisky
2013-10-16 20:27           ` Russell King - ARM Linux
2013-10-16 21:03             ` Troy Kisky
2013-10-16 22:27               ` Russell King - ARM Linux
2013-10-17  8:45       ` Russell King - ARM Linux
2013-10-03 20:48 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131003202751.GZ6192@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.