From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] FIXED sparse warning : drivers/cpuidle/cpuidle.c:27:1: warning: symbol 'cpuidle_dev' was
Date: Fri, 04 Oct 2013 08:37:37 +0000 [thread overview]
Message-ID: <20131004083737.GB6192@mwanda> (raw)
In-Reply-To: <1380739624-17257-1-git-send-email-sgr.m.pdy@gmail.com>
On Thu, Oct 03, 2013 at 12:04:40PM +0530, Sagar Padhye wrote:
> > > I checked that cpuidle_devices is only being used in cpuidle.c - hence
> > > thought that it can be made static and be removed from header.
> >
> > "cpuidle_devices" is actually used in drivers/cpuidle/coupled.c as well
> > so this breaks the build.
>
> Darn! I forgot 'clean build' part. sorry.
>
> > Even for "cpuidle_dev" the patch isn't right. It doesn't fix the
> > warning, for me. The DEFINE_PER_CPU() macro defines several variables
> > actually. Per CPU variables are a bit complicated and they have to have
> > globally unique names. So just ignore the Sparse warning for per CPU
> > variables.
> >
>
> Ok, let me look at my sparse log once again, will pick some other
> problem (any suggestions?)
You're on the right track. Just the details are wrong.
regards,
dan carpenter
prev parent reply other threads:[~2013-10-04 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 18:59 [PATCH] FIXED sparse warning : drivers/cpuidle/cpuidle.c:27:1: warning: symbol 'cpuidle_dev' was not Sagar Padhye
2013-10-02 19:24 ` [PATCH] FIXED sparse warning : drivers/cpuidle/cpuidle.c:27:1: warning: symbol 'cpuidle_dev' was Dan Carpenter
2013-10-03 6:34 ` [PATCH] FIXED sparse warning : drivers/cpuidle/cpuidle.c:27:1: warning: symbol 'cpuidle_dev' was not declared. Should it be static? Sagar Padhye
2013-10-03 6:46 ` [PATCH] FIXED sparse warning : drivers/cpuidle/cpuidle.c:27:1: warning: symbol 'cpuidle_dev' was Sagar Padhye
2013-10-04 8:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004083737.GB6192@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.