All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] bin/bitbake: Catch establish connection log messages
Date: Fri, 4 Oct 2013 16:23:43 +0200	[thread overview]
Message-ID: <20131004142343.GK6240@jama> (raw)
In-Reply-To: <1380892492.18603.601.camel@ted>

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

On Fri, Oct 04, 2013 at 02:14:52PM +0100, Richard Purdie wrote:
> If for example you try "bitbake -m" with an invalid BBSERVER, error
> messages are not dsplayed. This change ensures logging is in place

small typo         ^
                   displayed

> to catch and display such errors.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/bitbake/bin/bitbake b/bitbake/bin/bitbake
> index 222dabd..21a6c81 100755
> --- a/bitbake/bin/bitbake
> +++ b/bitbake/bin/bitbake
> @@ -297,8 +297,6 @@ def main():
>          server = servermodule.BitBakeXMLRPCClient(configParams.observe_only)
>          server.saveConnectionDetails(configParams.remote_server)
>  
> -    logger.removeHandler(handler)
> -
>      if not configParams.server_only:
>          # Collect the feature set for the UI
>          featureset = getattr(ui_module, "featureSet", [])
> @@ -310,6 +308,8 @@ def main():
>          for k in cleanedvars:
>              os.environ[k] = cleanedvars[k]
>  
> +        logger.removeHandler(handler)
> +
>          try:
>              return ui_module.main(server_connection.connection, server_connection.events, configParams)
>          finally:
> 
> 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

      reply	other threads:[~2013-10-04 14:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 13:14 [PATCH] bin/bitbake: Catch establish connection log messages Richard Purdie
2013-10-04 14:23 ` Martin Jansa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131004142343.GK6240@jama \
    --to=martin.jansa@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.