From: Joerg Roedel <joro@8bytes.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Andy Lutomirski <luto@amacapital.net>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Subject: Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning
Date: Fri, 4 Oct 2013 16:32:12 +0200 [thread overview]
Message-ID: <20131004143211.GA2717@8bytes.org> (raw)
In-Reply-To: <1380300815-1864-1-git-send-email-nhorman@tuxdriver.com>
On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote:
> The warning for the irq remapping broken check in intel_irq_remapping.c is
> pretty pointless. We need the warning, but we know where its comming from, the
> stack trace will always be the same, and it needlessly triggers things like
> Abrt. This changes the warning to just print a text warning about BIOS being
> broken, without the stack trace, then sets the appropriate taint bit. Since we
> automatically disable irq remapping, theres no need to contiue making Abrt jump
> at this problem
Applied to x86/vt-d, thanks Neil.
prev parent reply other threads:[~2013-10-04 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 16:53 [PATCH] iommu: Remove stack trace from broken irq remapping warning Neil Horman
2013-09-27 19:24 ` Andy Lutomirski
2013-09-27 19:41 ` Neil Horman
2013-10-03 17:21 ` Neil Horman
2013-10-03 19:21 ` Bjorn Helgaas
2013-10-03 20:08 ` Joerg Roedel
2013-10-03 20:26 ` Neil Horman
2013-10-04 14:32 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004143211.GA2717@8bytes.org \
--to=joro@8bytes.org \
--cc=bhelgaas@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nhorman@tuxdriver.com \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.