From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Simek <monstr@monstr.eu>
Cc: Joe Perches <joe@perches.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, Alan Tull <atull@altera.com>,
Pavel Machek <pavel@ucw.cz>, Dinh Nguyen <dinguyen@altera.com>,
Philip Balister <philip@balister.org>,
Alessandro Rubini <rubini@gnudd.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Jason Cooper <jason@lakedaemon.net>,
Yves Vandervennet <rocket.yvanderv@gmail.com>,
Kyle Teske <kyle.teske@ni.com>,
Josh Cartwright <joshc@eso.teric.us>,
Rob Landley <rob@landley.net>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Cesar Eduardo Barros <cesarb@cesarb.net>,
"David S. Miller" <davem@davemloft.net>,
David Brown <davidb@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Nicolas Pitre <nico@linaro.org>,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
Felipe Balbi <balbi@ti.com>,
linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH v2] fpga: Introduce new fpga subsystem
Date: Fri, 4 Oct 2013 09:26:54 -0700 [thread overview]
Message-ID: <20131004162654.GA16666@kroah.com> (raw)
In-Reply-To: <524EE9A0.2020404@monstr.eu>
On Fri, Oct 04, 2013 at 06:15:28PM +0200, Michal Simek wrote:
> > Probably all of the "return ret ?: count;" uses
> > would be more easily understood on 3 lines.
>
> This structure is also quite common in the kernel
> git grep "? :" | wc -l
> 415
>
> git grep "?:" | wc -l
> 541
And it should all be removed and fixed up properly to make it easier to
read and understand. Please don't add new instances of it, I sure will
not take it.
greg k-h
next prev parent reply other threads:[~2013-10-04 16:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 15:35 [RFC PATCH v2 0/1] FPGA subsystem core Michal Simek
2013-10-02 15:35 ` [RFC PATCH v2] fpga: Introduce new fpga subsystem Michal Simek
2013-10-02 16:06 ` Joe Perches
2013-10-04 16:15 ` Michal Simek
2013-10-04 16:26 ` Greg Kroah-Hartman [this message]
2013-10-02 17:46 ` Jason Gunthorpe
2013-10-04 16:28 ` Michal Simek
2013-10-04 17:05 ` Jason Gunthorpe
2013-10-04 18:50 ` Alan Tull
2013-10-02 19:00 ` [RFC PATCH v2 0/1] FPGA subsystem core H. Peter Anvin
2013-10-03 6:49 ` Pavel Machek
2013-10-04 13:57 ` Michal Simek
2013-10-04 14:16 ` Greg Kroah-Hartman
2013-10-04 14:21 ` H. Peter Anvin
2013-10-04 14:28 ` Michal Simek
2013-10-04 16:46 ` H. Peter Anvin
2013-10-04 17:44 ` Michal Simek
2013-10-04 18:12 ` H. Peter Anvin
2013-10-04 23:33 ` Greg Kroah-Hartman
2013-10-04 23:49 ` Jason Gunthorpe
2013-10-05 4:00 ` H. Peter Anvin
2013-10-05 5:10 ` Jason Gunthorpe
2013-10-05 5:34 ` H. Peter Anvin
2013-10-05 6:53 ` Michal Simek
[not found] ` <c59c68b8-2565-45c5-bfe9-574b76f3f9bc@email.android.com>
2013-10-07 13:11 ` Michal Simek
2013-10-07 14:55 ` H. Peter Anvin
2013-10-07 15:03 ` Michal Simek
2013-10-07 15:07 ` H. Peter Anvin
2013-10-08 13:00 ` Michal Simek
2013-10-08 16:49 ` Alan Tull
2013-10-08 21:42 ` Greg Kroah-Hartman
[not found] ` <CANk1AXS9fpypVVWgvvUCZjKXDvLPpB7=kCNucwFcktgBHmV37w@mail.gmail.com>
[not found] ` <20131009014027.GA17066@kroah.com>
[not found] ` <5254EC8A.8060609@monstr.eu>
[not found] ` <20131009055332.GA4510@kroah.com>
[not found] ` <52550638.2080301@monstr.eu>
[not found] ` <52556585.3050603@zytor.com>
[not found] ` <20131009192439.GC18611@kroah.com>
[not found] ` <5255BE71.8010801@zytor.com>
2013-10-09 21:07 ` Jason Gunthorpe
2013-10-09 22:21 ` H. Peter Anvin
2013-10-05 17:33 ` Jason Gunthorpe
2013-10-05 6:56 ` Michal Simek
2013-10-04 23:50 ` H. Peter Anvin
2013-10-05 6:49 ` Michal Simek
2013-10-08 17:00 ` Alan Tull
2013-10-08 21:44 ` Greg Kroah-Hartman
2013-10-08 23:47 ` delicious quinoa
2013-10-09 1:41 ` Greg Kroah-Hartman
2013-10-04 18:26 ` Alan Tull
2013-10-03 21:46 ` Alan Tull
2013-10-04 15:27 ` Michal Simek
2013-10-04 18:30 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004162654.GA16666@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=atull@altera.com \
--cc=balbi@ti.com \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=dinguyen@altera.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=joe@perches.com \
--cc=joshc@eso.teric.us \
--cc=kyle.teske@ni.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mark.langsdorf@calxeda.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pavel@ucw.cz \
--cc=philip@balister.org \
--cc=rob@landley.net \
--cc=rocket.yvanderv@gmail.com \
--cc=rubini@gnudd.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.