All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Olof Johansson <olof@lixom.net>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: Use of drivers/platform and matching include?
Date: Sat, 5 Oct 2013 10:13:23 -0700	[thread overview]
Message-ID: <20131005171323.GB5780@kroah.com> (raw)
In-Reply-To: <CAOesGMjxwmr0Vo0Puc-nZntgXLy6D1PTohz=C+fFukP_Eu1iQg@mail.gmail.com>

On Fri, Oct 04, 2013 at 09:48:41AM -0700, Olof Johansson wrote:
> On Fri, Oct 4, 2013 at 6:22 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Fri, Oct 04, 2013 at 12:41:28PM +0100, Russell King - ARM Linux wrote:
> >>
> >> So, no, there will be no new drivers under arch/arm.  They must be in the
> >> drivers subtree somewhere.
> >
> > I have no objection with this, and encourage it.
> 
> Ok, so these are some of the requirements as far as I see it:
> 
> * No per-vendor driver dumping ground under drivers/* (i.e. no
> drivers/platform/<soc vendor>/)

Yes.

> * No weirdly constructed single-driver directories directly under
> drivers/* (we already have a few and should look at moving those)
> because nothing else fits

Yes, we should see about moving some of the ones we currently have,
drivers/ntb/ is one example that I couldn't think of a better place to
put it.  I guess drivers/misc/ really would be best for a bunch of
these.  As an example, drivers/misc/mic/ is way larger than
drivers/ntb/.

> * We need some sort of convention on dependencies. Several of these
> are more libraries than drivers, i.e. we'll have cross-calls for
> things like queue management, resource allocation, etc. So having a
> single location to hold most of these makes sense instead of
> everything cross-depending on everything else.

What's wrong with lib/ for that?  Isn't that supposed to be where this
type of thing goes?

> Based on the above, how about we create something like
> drivers/resourcemgr to hold these?   I think at least parts of the
> mvebu-mbus driver that ended up under drivers/bus might be a fit to
> move there. The APM queue allocator would likely be a fit, and maybe
> some of the qualcomm stuff. Kumar, what are your thoughts on that?
> Greg?

lib/ does look "big", but we also have kernel/ for the current resource
stuff, as it is core code.  Why not use that?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: Use of drivers/platform and matching include?
Date: Sat, 5 Oct 2013 10:13:23 -0700	[thread overview]
Message-ID: <20131005171323.GB5780@kroah.com> (raw)
In-Reply-To: <CAOesGMjxwmr0Vo0Puc-nZntgXLy6D1PTohz=C+fFukP_Eu1iQg@mail.gmail.com>

On Fri, Oct 04, 2013 at 09:48:41AM -0700, Olof Johansson wrote:
> On Fri, Oct 4, 2013 at 6:22 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Fri, Oct 04, 2013 at 12:41:28PM +0100, Russell King - ARM Linux wrote:
> >>
> >> So, no, there will be no new drivers under arch/arm.  They must be in the
> >> drivers subtree somewhere.
> >
> > I have no objection with this, and encourage it.
> 
> Ok, so these are some of the requirements as far as I see it:
> 
> * No per-vendor driver dumping ground under drivers/* (i.e. no
> drivers/platform/<soc vendor>/)

Yes.

> * No weirdly constructed single-driver directories directly under
> drivers/* (we already have a few and should look at moving those)
> because nothing else fits

Yes, we should see about moving some of the ones we currently have,
drivers/ntb/ is one example that I couldn't think of a better place to
put it.  I guess drivers/misc/ really would be best for a bunch of
these.  As an example, drivers/misc/mic/ is way larger than
drivers/ntb/.

> * We need some sort of convention on dependencies. Several of these
> are more libraries than drivers, i.e. we'll have cross-calls for
> things like queue management, resource allocation, etc. So having a
> single location to hold most of these makes sense instead of
> everything cross-depending on everything else.

What's wrong with lib/ for that?  Isn't that supposed to be where this
type of thing goes?

> Based on the above, how about we create something like
> drivers/resourcemgr to hold these?   I think at least parts of the
> mvebu-mbus driver that ended up under drivers/bus might be a fit to
> move there. The APM queue allocator would likely be a fit, and maybe
> some of the qualcomm stuff. Kumar, what are your thoughts on that?
> Greg?

lib/ does look "big", but we also have kernel/ for the current resource
stuff, as it is core code.  Why not use that?

thanks,

greg k-h

  parent reply	other threads:[~2013-10-05 17:23 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 14:45 Use of drivers/platform and matching include? Kumar Gala
2013-10-03 14:45 ` Kumar Gala
2013-10-03 15:27 ` Greg Kroah-Hartman
2013-10-03 15:27   ` Greg Kroah-Hartman
2013-10-03 16:21   ` Kumar Gala
2013-10-03 16:21     ` Kumar Gala
2013-10-03 16:25     ` Greg Kroah-Hartman
2013-10-03 16:25       ` Greg Kroah-Hartman
2013-10-03 16:38       ` Kumar Gala
2013-10-03 16:38         ` Kumar Gala
2013-10-03 16:46 ` Olof Johansson
2013-10-03 16:46   ` Olof Johansson
2013-10-03 17:09   ` Greg Kroah-Hartman
2013-10-03 17:09     ` Greg Kroah-Hartman
2013-10-03 17:54     ` Olof Johansson
2013-10-03 17:54       ` Olof Johansson
2013-10-04 11:18       ` Catalin Marinas
2013-10-04 11:18         ` Catalin Marinas
2013-10-04 11:50       ` Russell King - ARM Linux
2013-10-04 11:50         ` Russell King - ARM Linux
2013-10-04 11:43     ` Russell King - ARM Linux
2013-10-04 11:43       ` Russell King - ARM Linux
2013-10-04 12:03       ` Catalin Marinas
2013-10-04 12:03         ` Catalin Marinas
2013-10-04 11:41   ` Russell King - ARM Linux
2013-10-04 11:41     ` Russell King - ARM Linux
2013-10-04 13:22     ` Greg Kroah-Hartman
2013-10-04 13:22       ` Greg Kroah-Hartman
2013-10-04 16:48       ` Olof Johansson
2013-10-04 16:48         ` Olof Johansson
2013-10-04 19:29         ` Santosh Shilimkar
2013-10-04 19:29           ` Santosh Shilimkar
2013-10-04 19:29           ` Santosh Shilimkar
2013-10-05 17:13         ` Greg Kroah-Hartman [this message]
2013-10-05 17:13           ` Greg Kroah-Hartman
2013-10-08  0:26           ` Rohit Vaswani
2013-10-08  0:26             ` Rohit Vaswani
2013-10-08  2:19             ` Greg Kroah-Hartman
2013-10-08  2:19               ` Greg Kroah-Hartman
2013-10-07  6:48 ` Andi Shyti
2013-10-07  6:48   ` Andi Shyti
2013-10-08 17:57   ` Rohit Vaswani
2013-10-08 17:57     ` Rohit Vaswani
2013-10-09  6:04     ` Andi Shyti
2013-10-09  6:04       ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131005171323.GB5780@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=galak@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.