All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RFC] block: use a separate plug list for blk-mq requests
Date: Sun, 6 Oct 2013 12:15:08 -0600	[thread overview]
Message-ID: <20131006181508.GF8252@kernel.dk> (raw)
In-Reply-To: <20131006160430.GA5959@infradead.org>

On Sun, Oct 06 2013, Christoph Hellwig wrote:
> blk_flush_plug_list became a bit of a mess with the introduction of blk-mq,
> so I started looking into separating the blk-mq handling from it.  Turns
> out that by doing this we can streamline the blk-mq submission path a lot.
> 
> If we branch out to a blk-mq specific code path early we can do the list sort
> based on the hw ctx instead of the queue and thus avoid the later improvised
> loop to sort again.  In addition we can also remove the hw irq disabling in
> the submission path entirely and collapse a couple of functions in blk-mq.c,
> all at the cost of an additional list_head in struct blk_plug which can go
> away again as soon as we remove old-school request_fn based drivers.

Thanks, I'll take a look at this. The plugging was done mostly hacky
when implementing it, it was meant to be revisited. So definitely room
for improvement there.

-- 
Jens Axboe


  reply	other threads:[~2013-10-06 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06 16:04 [PATCH, RFC] block: use a separate plug list for blk-mq requests Christoph Hellwig
2013-10-06 18:15 ` Jens Axboe [this message]
2013-10-22  6:16   ` Christoph Hellwig
2013-10-22 10:51     ` Jens Axboe
2013-10-22 11:41       ` Christoph Hellwig
2013-10-22 11:55         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131006181508.GF8252@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.