From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 04/21] toolchain: move helpers.mk into toolchain-external/
Date: Sun, 6 Oct 2013 23:26:08 +0200 [thread overview]
Message-ID: <20131006232608.432630fe@skate> (raw)
In-Reply-To: <87a9imdwm5.fsf@dell.be.48ers.dk>
Dear Peter Korsgaard,
On Sun, 06 Oct 2013 21:31:46 +0200, Peter Korsgaard wrote:
> Thomas> -include toolchain/helpers.mk
> Thomas> -
>
> That doesn't seem right as we have:
>
> git grep copy_toolchain package/
> package/glibc/glibc.mk: $(call copy_toolchain_lib_root,$(STAGING_DIR)/,,
Oh, I'm impressed how well you know the code, even code that I have
written. We really need some kind of "test suite" to check patches or
something like that: a patch set such as this toolchain-related patch
set is really a pain to test in all the various possible conditions. I
did test the internal backend, but only with uClibc toolchain.
I'll rework my patch series.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-06 21:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 14:19 [Buildroot] [PATCHv2 00/21] Toolchain updates: package infra, musl support, Linaro updates Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 01/21] toolchain-crosstool-ng: remove support Thomas Petazzoni
2013-10-06 18:53 ` Peter Korsgaard
2013-10-06 14:19 ` [Buildroot] [PATCHv2 02/21] docs: update manual after Crosstool-NG backend removal Thomas Petazzoni
2013-10-06 18:53 ` Peter Korsgaard
2013-10-06 14:19 ` [Buildroot] [PATCHv2 03/21] toolchain-external: make ext-tool.mk includable in all cases Thomas Petazzoni
2013-10-06 18:55 ` Peter Korsgaard
2013-10-06 14:19 ` [Buildroot] [PATCHv2 04/21] toolchain: move helpers.mk into toolchain-external/ Thomas Petazzoni
2013-10-06 19:31 ` Peter Korsgaard
2013-10-06 21:26 ` Thomas Petazzoni [this message]
2013-10-06 21:40 ` Peter Korsgaard
2013-10-06 14:19 ` [Buildroot] [PATCHv2 05/21] toolchain: introduce a virtual package Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 06/21] toolchain-buildroot: convert to the package infrastructure Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 07/21] toolchain: intermediate .mk files no longer needed Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 08/21] package: package-based implementation of source, external-deps and legal-info Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 09/21] package: remove useless SHOW_EXTERNAL_DEPS support Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 10/21] package: add a <pkg>_EXTRA_DOWNLOADS variable Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 11/21] toolchain-external: convert to the package infrastructure Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 12/21] dependencies: remove useless targets Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 13/21] toolchain-external: conditionalize the installation of libraries Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 14/21] toolchain-external: modify the wildcard logic for shared libraries copying Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 15/21] toolchain-external: add support for musl C library Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 16/21] toolchain-external: improve help text of some options Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 17/21] busybox: add patches to fix build with the musl C library Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 18/21] toolchain-external: update Linaro ARM toolchain Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 19/21] toolchain-external: update Linaro AArch64 toolchain Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 20/21] toolchain-external: improve target library copy logic Thomas Petazzoni
2013-10-06 14:19 ` [Buildroot] [PATCHv2 21/21] toolchain-external: fix Linaro ARM toolchain support Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006232608.432630fe@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.