From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Mon, 7 Oct 2013 12:09:22 +0200 Subject: [PATCH 3/5] DRM: Armada: Add support for ARGB 32x64 or 64x32 hardware cursors In-Reply-To: <20131007094008.GH12758@n2100.arm.linux.org.uk> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007110141.27f1ac25@armhf> <20131007094008.GH12758@n2100.arm.linux.org.uk> Message-ID: <20131007120922.47df03b6@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 7 Oct 2013 10:40:08 +0100 Russell King - ARM Linux wrote: > > > This patch adds ARGB hardware cursor support to the DRM driver for the > > > Marvell Armada SoCs. ARGB cursors are supported at either 32x64 or > > > 64x32 resolutions. > > [snip] > > > > I don't see the interest of such cursors. Actually, most often, the > > cursors are 64x64 and 'A' is either 0 or 0xff. As the Armada 510 > > supports 64x64 cursors with transparency, it would be more useful to > > implement these ones... > > Sorry, you're completely wrong there. Xorg uses an alphablended cursor. > This patch is a result of trialling each of the Armada's cursor options > and this is the only one which results in a reasonable looking cursor. Strange. I am using the 64x64 cursor with transparency of the 510 for many months and I never saw any problem. If you absolutely want to have all transparency shades, you should accept 64x64 cursors and test if they may be rendered as 64x32 or 32x64, i.e. test that there is only pure transparency in the non-rendered rectangles... -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH 3/5] DRM: Armada: Add support for ARGB 32x64 or 64x32 hardware cursors Date: Mon, 7 Oct 2013 12:09:22 +0200 Message-ID: <20131007120922.47df03b6@armhf> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007110141.27f1ac25@armhf> <20131007094008.GH12758@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20131007094008.GH12758@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: Jason Cooper , David Airlie , dri-devel@lists.freedesktop.org, Rob Clark , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCA3IE9jdCAyMDEzIDEwOjQwOjA4ICswMTAwClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51 eCA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cgo+ID4gPiBUaGlzIHBhdGNoIGFkZHMg QVJHQiBoYXJkd2FyZSBjdXJzb3Igc3VwcG9ydCB0byB0aGUgRFJNIGRyaXZlciBmb3IgdGhlCj4g PiA+IE1hcnZlbGwgQXJtYWRhIFNvQ3MuICBBUkdCIGN1cnNvcnMgYXJlIHN1cHBvcnRlZCBhdCBl aXRoZXIgMzJ4NjQgb3IKPiA+ID4gNjR4MzIgcmVzb2x1dGlvbnMuICAKPiA+IAlbc25pcF0KPiA+ IAo+ID4gSSBkb24ndCBzZWUgdGhlIGludGVyZXN0IG9mIHN1Y2ggY3Vyc29ycy4gQWN0dWFsbHks IG1vc3Qgb2Z0ZW4sIHRoZQo+ID4gY3Vyc29ycyBhcmUgNjR4NjQgYW5kICdBJyBpcyBlaXRoZXIg MCBvciAweGZmLiBBcyB0aGUgQXJtYWRhIDUxMAo+ID4gc3VwcG9ydHMgNjR4NjQgY3Vyc29ycyB3 aXRoIHRyYW5zcGFyZW5jeSwgaXQgd291bGQgYmUgbW9yZSB1c2VmdWwgdG8KPiA+IGltcGxlbWVu dCB0aGVzZSBvbmVzLi4uICAKPiAKPiBTb3JyeSwgeW91J3JlIGNvbXBsZXRlbHkgd3JvbmcgdGhl cmUuICBYb3JnIHVzZXMgYW4gYWxwaGFibGVuZGVkIGN1cnNvci4KPiBUaGlzIHBhdGNoIGlzIGEg cmVzdWx0IG9mIHRyaWFsbGluZyBlYWNoIG9mIHRoZSBBcm1hZGEncyBjdXJzb3Igb3B0aW9ucwo+ IGFuZCB0aGlzIGlzIHRoZSBvbmx5IG9uZSB3aGljaCByZXN1bHRzIGluIGEgcmVhc29uYWJsZSBs b29raW5nIGN1cnNvci4KClN0cmFuZ2UuIEkgYW0gdXNpbmcgdGhlIDY0eDY0IGN1cnNvciB3aXRo IHRyYW5zcGFyZW5jeSBvZiB0aGUgNTEwIGZvcgptYW55IG1vbnRocyBhbmQgSSBuZXZlciBzYXcg YW55IHByb2JsZW0uCgpJZiB5b3UgYWJzb2x1dGVseSB3YW50IHRvIGhhdmUgYWxsIHRyYW5zcGFy ZW5jeSBzaGFkZXMsIHlvdSBzaG91bGQKYWNjZXB0IDY0eDY0IGN1cnNvcnMgYW5kIHRlc3QgaWYg dGhleSBtYXkgYmUgcmVuZGVyZWQgYXMgNjR4MzIgb3IgMzJ4NjQsCmkuZS4gdGVzdCB0aGF0IHRo ZXJlIGlzIG9ubHkgcHVyZSB0cmFuc3BhcmVuY3kgaW4gdGhlIG5vbi1yZW5kZXJlZApyZWN0YW5n bGVzLi4uCgotLSAKS2VuIGFyIGMnaGVudGHDsQl8CSAgICAgICoqIEJyZWl6aCBoYSBMaW51eCBh dGF2ISAqKgpKZWYJCXwJCWh0dHA6Ly9tb2luZWpmLmZyZWUuZnIvCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==