All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Doug Thompson <dougthompson@xmission.com>,
	Borislav Petkov <bp@suse.de>, Baruch Siach <baruch@tkos.co.il>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@men.de>
Subject: Re: [PATCH] mpc85xx_edac: Remove unused function
Date: Mon, 7 Oct 2013 17:34:41 +0200	[thread overview]
Message-ID: <20131007153441.GA12771@pd.tnic> (raw)
In-Reply-To: <1381158835-10804-1-git-send-email-treding@nvidia.com>

I'm guessing this one is for Johannes. CCed...

On Mon, Oct 07, 2013 at 05:13:55PM +0200, Thierry Reding wrote:
> Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code)
> removed the struct platform_driver that held the last reference to the
> mpc85xx_pci_err_remove() function. Remove the function since it is
> effectively dead code.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/edac/mpc85xx_edac.c | 23 -----------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 3eb32f6..b1e7106 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -326,29 +326,6 @@ err:
>  	return res;
>  }
>  EXPORT_SYMBOL(mpc85xx_pci_err_probe);
> -
> -static int mpc85xx_pci_err_remove(struct platform_device *op)
> -{
> -	struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
> -	struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
> -
> -	edac_dbg(0, "\n");
> -
> -	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
> -		 orig_pci_err_cap_dr);
> -
> -	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
> -
> -	edac_pci_del_device(pci->dev);
> -
> -	if (edac_op_state == EDAC_OPSTATE_INT)
> -		irq_dispose_mapping(pdata->irq);
> -
> -	edac_pci_free_ctl_info(pci);
> -
> -	return 0;
> -}
> -
>  #endif				/* CONFIG_PCI */
>  
>  /**************************** L2 Err device ***************************/
> -- 
> 1.8.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2013-10-07 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07 15:13 [PATCH] mpc85xx_edac: Remove unused function Thierry Reding
2013-10-07 15:34 ` Borislav Petkov [this message]
2013-10-08  6:39 ` Johannes Thumshirn
2013-10-08  9:52   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131007153441.GA12771@pd.tnic \
    --to=bp@alien8.de \
    --cc=baruch@tkos.co.il \
    --cc=bp@suse.de \
    --cc=dougthompson@xmission.com \
    --cc=johannes.thumshirn@men.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.