From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 07 Oct 2013 18:29:21 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:35180 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6868731Ab3JGQ3TK6iJq (ORCPT ); Mon, 7 Oct 2013 18:29:19 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id r97GTHhJ014836; Mon, 7 Oct 2013 18:29:17 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id r97GTHBx014835; Mon, 7 Oct 2013 18:29:17 +0200 Date: Mon, 7 Oct 2013 18:29:17 +0200 From: Ralf Baechle To: Markos Chandras Cc: linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: fix mapstart when using initrd Message-ID: <20131007162917.GB1615@linux-mips.org> References: <1379945426-32205-1-git-send-email-ashoks@broadcom.com> <20131007160821.GA1615@linux-mips.org> <5252DCEB.8070909@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5252DCEB.8070909@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38229 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, Oct 07, 2013 at 05:10:19PM +0100, Markos Chandras wrote: > On 10/07/13 17:08, Ralf Baechle wrote: > >On Mon, Sep 23, 2013 at 07:40:26PM +0530, Ashok Kumar wrote: > >>Date: Mon, 23 Sep 2013 19:40:26 +0530 > >>From: Ashok Kumar > >>To: linux-mips@linux-mips.org, gerg@uclinux.org > >>cc: ralf@linux-mips.org, Ashok Kumar > >>Subject: [PATCH] MIPS: fix mapstart when using initrd > >>Content-Type: text/plain > >> > >>When initrd is present in the PFN right after the _end, bootmem > >>bitmap(mapstart) overwrites it. So check for initrd_end in > >>mapstart calculation. > >> > >>Signed-off-by: Ashok Kumar > >>--- > >>This is seen after the commit > >>"mips: fix start of free memory when using initrd" > >>in git://git.linux-mips.org/pub/scm/ralf/upstream-sfr.git branch > >> > >>Tested the image on MIPS platform creating the above > >>said scenario and initrd was corrupted. > > > >And it gloriously breaks the build if CONFIG_BLK_DEV_INITRD is disabled. > >Now most configurations will fail with something like: > > > >[...] > > LD vmlinux > >arch/mips/built-in.o: In function `setup_arch': > >(.init.text+0xff8): undefined reference to `initrd_end' > >arch/mips/built-in.o: In function `setup_arch': > >(.init.text+0xffc): undefined reference to `initrd_end' > >make[2]: *** [vmlinux] Error 1 > >make[1]: *** [sub-make] Error 2 > >make: *** [all] Error 2 > >make: Leaving directory `/home/ralf/src/linux/obj/lasat-build' > > > > Ralf > > > Hi Ralf, > > I just sent a patch for that > > http://patchwork.linux-mips.org/patch/6028/ Yes, I noticed that. I folded that into Greg's original patch as well. And now back to the scheduled development program :) Btw, brownie points for an #ifdef-less fix ... Ralf