From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Date: Mon, 7 Oct 2013 09:50:57 -0700 Message-ID: <20131007165056.GA24536@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> <20131003004805.GL6768@jonmason-lab> <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga14.intel.com ([143.182.124.37]:49018 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756378Ab3JGQvB (ORCPT ); Mon, 7 Oct 2013 12:51:01 -0400 Content-Disposition: inline In-Reply-To: <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Ralf Baechle , Michael Ellerman , Benjamin Herrenschmidt , Martin Schwidefsky , Ingo Molnar , Tejun Heo , Dan Williams , Andy King , Matt Porter , stable@vger.kernel.org, linux-pci@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux390@de.ibm.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-ide@vger.kernel.org, iss_storagedev@hp.com, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-driver@qlogic.com, Solarflare linux maintainers , "VMware, Inc." On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/ntb/ntb_hw.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > > > index de2062c..eccd5e5 100644 > > > --- a/drivers/ntb/ntb_hw.c > > > +++ b/drivers/ntb/ntb_hw.c > > > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > > > /* On SNB, the link interrupt is always tied to 4th vector. If > > > * we can't get all 4, then we can't use MSI-X. > > > */ > > > - if (ndev->hw_type != BWD_HW) { > > > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { > > > > Nack, this check is unnecessary. > > If SNB can do more than SNB_MSIX_CNT MSI-Xs then this check is needed > to enable less than maximum MSI-Xs in case the maximum was not allocated. > Otherwise SNB will fallback to single MSI instead of multiple MSI-Xs. Per the comment in the code snippet above, "If we can't get all 4, then we can't use MSI-X". There is already a check to see if more than 4 were acquired. So it's not possible to hit this. Even if it was, don't use SNB_MSIX_CNT here (limits.msix_cnt is the preferred variable). Also, the "()" are unnecessary. Thanks, Jon > -- > Regards, > Alexander Gordeev > agordeev@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 07 Oct 2013 18:51:21 +0200 (CEST) Received: from mga11.intel.com ([192.55.52.93]:47880 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6868735Ab3JGQvRUpeEw (ORCPT ); Mon, 7 Oct 2013 18:51:17 +0200 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 07 Oct 2013 09:50:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,1051,1371106800"; d="scan'208";a="406713353" Received: from jonmason-lab.ch.intel.com (HELO jonmason-lab) ([143.182.51.14]) by fmsmga001.fm.intel.com with ESMTP; 07 Oct 2013 09:50:57 -0700 Date: Mon, 7 Oct 2013 09:50:57 -0700 From: Jon Mason To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Ralf Baechle , Michael Ellerman , Benjamin Herrenschmidt , Martin Schwidefsky , Ingo Molnar , Tejun Heo , Dan Williams , Andy King , Matt Porter , stable@vger.kernel.org, linux-pci@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux390@de.ibm.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-ide@vger.kernel.org, iss_storagedev@hp.com, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-driver@qlogic.com, Solarflare linux maintainers , "VMware, Inc." , linux-scsi@vger.kernel.org Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Message-ID: <20131007165056.GA24536@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> <20131003004805.GL6768@jonmason-lab> <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38235 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: jon.mason@intel.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/ntb/ntb_hw.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > > > index de2062c..eccd5e5 100644 > > > --- a/drivers/ntb/ntb_hw.c > > > +++ b/drivers/ntb/ntb_hw.c > > > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > > > /* On SNB, the link interrupt is always tied to 4th vector. If > > > * we can't get all 4, then we can't use MSI-X. > > > */ > > > - if (ndev->hw_type != BWD_HW) { > > > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { > > > > Nack, this check is unnecessary. > > If SNB can do more than SNB_MSIX_CNT MSI-Xs then this check is needed > to enable less than maximum MSI-Xs in case the maximum was not allocated. > Otherwise SNB will fallback to single MSI instead of multiple MSI-Xs. Per the comment in the code snippet above, "If we can't get all 4, then we can't use MSI-X". There is already a check to see if more than 4 were acquired. So it's not possible to hit this. Even if it was, don't use SNB_MSIX_CNT here (limits.msix_cnt is the preferred variable). Also, the "()" are unnecessary. Thanks, Jon > -- > Regards, > Alexander Gordeev > agordeev@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon.mason@intel.com (Jon Mason) Date: Mon, 7 Oct 2013 09:50:57 -0700 Subject: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt In-Reply-To: <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> <20131003004805.GL6768@jonmason-lab> <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> Message-ID: <20131007165056.GA24536@jonmason-lab> On Sat, Oct 05, 2013@11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013@05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013@12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/ntb/ntb_hw.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > > > index de2062c..eccd5e5 100644 > > > --- a/drivers/ntb/ntb_hw.c > > > +++ b/drivers/ntb/ntb_hw.c > > > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > > > /* On SNB, the link interrupt is always tied to 4th vector. If > > > * we can't get all 4, then we can't use MSI-X. > > > */ > > > - if (ndev->hw_type != BWD_HW) { > > > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { > > > > Nack, this check is unnecessary. > > If SNB can do more than SNB_MSIX_CNT MSI-Xs then this check is needed > to enable less than maximum MSI-Xs in case the maximum was not allocated. > Otherwise SNB will fallback to single MSI instead of multiple MSI-Xs. Per the comment in the code snippet above, "If we can't get all 4, then we can't use MSI-X". There is already a check to see if more than 4 were acquired. So it's not possible to hit this. Even if it was, don't use SNB_MSIX_CNT here (limits.msix_cnt is the preferred variable). Also, the "()" are unnecessary. Thanks, Jon > -- > Regards, > Alexander Gordeev > agordeev at redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ozlabs.org (Postfix) with ESMTP id E82FB2C034D for ; Tue, 8 Oct 2013 03:51:17 +1100 (EST) Date: Mon, 7 Oct 2013 09:50:57 -0700 From: Jon Mason To: Alexander Gordeev Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Message-ID: <20131007165056.GA24536@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> <20131003004805.GL6768@jonmason-lab> <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> Cc: linux-mips@linux-mips.org, "VMware, Inc." , linux-nvme@lists.infradead.org, linux-ide@vger.kernel.org, stable@vger.kernel.org, linux-s390@vger.kernel.org, Andy King , linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Ingo Molnar , linux-pci@vger.kernel.org, iss_storagedev@hp.com, linux-driver@qlogic.com, Tejun Heo , Bjorn Helgaas , Dan Williams , Solarflare linux maintainers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , e1000-devel@lists.sourceforge.net, Martin Schwidefsky , linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/ntb/ntb_hw.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > > > index de2062c..eccd5e5 100644 > > > --- a/drivers/ntb/ntb_hw.c > > > +++ b/drivers/ntb/ntb_hw.c > > > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > > > /* On SNB, the link interrupt is always tied to 4th vector. If > > > * we can't get all 4, then we can't use MSI-X. > > > */ > > > - if (ndev->hw_type != BWD_HW) { > > > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { > > > > Nack, this check is unnecessary. > > If SNB can do more than SNB_MSIX_CNT MSI-Xs then this check is needed > to enable less than maximum MSI-Xs in case the maximum was not allocated. > Otherwise SNB will fallback to single MSI instead of multiple MSI-Xs. Per the comment in the code snippet above, "If we can't get all 4, then we can't use MSI-X". There is already a check to see if more than 4 were acquired. So it's not possible to hit this. Even if it was, don't use SNB_MSIX_CNT here (limits.msix_cnt is the preferred variable). Also, the "()" are unnecessary. Thanks, Jon > -- > Regards, > Alexander Gordeev > agordeev@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt Date: Mon, 7 Oct 2013 09:50:57 -0700 Message-ID: <20131007165056.GA24536@jonmason-lab> References: <5d9c5b2d3bbc444ff32bddeece7a239d046bd79c.1380703263.git.agordeev@redhat.com> <20131003004805.GL6768@jonmason-lab> <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Ralf Baechle , Michael Ellerman , Benjamin Herrenschmidt , Martin Schwidefsky , Ingo Molnar , Tejun Heo , Dan Williams , Andy King , Matt Porter , stable@vger.kernel.org, linux-pci@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux390@de.ibm.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-ide@vger.kernel.org, iss_storagedev@hp.com, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-driver@qlogic.com, Solarflare linux maintainers , "VMware, Inc." Return-path: Content-Disposition: inline In-Reply-To: <20131005214303.GA21589@dhcp-26-207.brq.redhat.com> Sender: linux-ide-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/ntb/ntb_hw.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > > > index de2062c..eccd5e5 100644 > > > --- a/drivers/ntb/ntb_hw.c > > > +++ b/drivers/ntb/ntb_hw.c > > > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > > > /* On SNB, the link interrupt is always tied to 4th vector. If > > > * we can't get all 4, then we can't use MSI-X. > > > */ > > > - if (ndev->hw_type != BWD_HW) { > > > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { > > > > Nack, this check is unnecessary. > > If SNB can do more than SNB_MSIX_CNT MSI-Xs then this check is needed > to enable less than maximum MSI-Xs in case the maximum was not allocated. > Otherwise SNB will fallback to single MSI instead of multiple MSI-Xs. Per the comment in the code snippet above, "If we can't get all 4, then we can't use MSI-X". There is already a check to see if more than 4 were acquired. So it's not possible to hit this. Even if it was, don't use SNB_MSIX_CNT here (limits.msix_cnt is the preferred variable). Also, the "()" are unnecessary. Thanks, Jon > -- > Regards, > Alexander Gordeev > agordeev@redhat.com