All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andre Richter <andre.o.richter@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: file_inode() vs f_mapping->host
Date: Mon, 7 Oct 2013 20:03:57 +0100	[thread overview]
Message-ID: <20131007190357.GA13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAKqeN29hu55Q0qXioaZKAppK-aA68rCaDUFg2z2AvUSEnnyMDA@mail.gmail.com>

On Mon, Oct 07, 2013 at 01:08:09PM +0200, Andre Richter wrote:
> Hi all,
> 
> in this thread ( https://lkml.org/lkml/2013/3/17/128 ), Al Viro argues
> that file_inode() is not equal to f_mapping->host in certain cases.
> 
> I'm asking, because in arch/x86/kernel/msr.c, msr_seek() retrieves the
> inode via f_mapping while one function later, msr_read() uses
> file_inode().
> Is this on purpose?

Both of those should use file_inode(), but in that case both expressions
yield the same value.  And no, it's not on purpose in case of msr.c -
just a historical accident.

      reply	other threads:[~2013-10-07 19:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07 11:08 file_inode() vs f_mapping->host Andre Richter
2013-10-07 19:03 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131007190357.GA13318@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=andre.o.richter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.