From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests generic/260: get correct trimmed bytes
Date: Tue, 8 Oct 2013 11:45:28 +1100 [thread overview]
Message-ID: <20131008004528.GS4446@dastard> (raw)
In-Reply-To: <1380868376-16783-1-git-send-email-eguan@redhat.com>
On Fri, Oct 04, 2013 at 02:32:56PM +0800, Eryu Guan wrote:
> Starting from util-linux v2.23 fstrim(1) reports trimmed bytes
> differently, e.g.
>
> new fstrim: /mnt/ext4: 9.7 GiB (10411118592 bytes) trimmed
> old fstrim: /mnt/ext4: 10411118592 bytes were trimmed
>
> generic/260 reports syntax error
>
> +./tests/generic/260: line 111: [: 9.7: integer expression expected
> +./tests/generic/260: line 121: [: 9.7: integer expression expected
> +./tests/generic/260: line 183: [: 9.7: integer expression expected
>
> Add a new filter called _filter_fstrim in common/filter and get the
> correct trimmed bytes in generic/260, so the test passes with both old
> and new fstrim.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> v2: add _filter_fstrim to filter the output as Dave suggested
Looks good!
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-08 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 11:57 [PATCH] xfstests generic/260: get correct trimmed bytes Eryu Guan
2013-10-04 1:07 ` Dave Chinner
2013-10-04 6:32 ` [PATCH v2] " Eryu Guan
2013-10-08 0:45 ` Dave Chinner [this message]
2013-10-16 20:20 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008004528.GS4446@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.