From: Pratyush Anand <pratyush.anand@st.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: designware: Make dw_pcie_rd_own_conf(), etc., static
Date: Tue, 8 Oct 2013 11:36:43 +0530 [thread overview]
Message-ID: <20131008060643.GA13048@pratyush-vbox> (raw)
In-Reply-To: <CAErSpo6KauiOBXh3QOS9=6QC_bjQqTgiDtnCAo1eb0d=uKgo-A@mail.gmail.com>
On Tue, Oct 08, 2013 at 08:07:24AM +0800, Bjorn Helgaas wrote:
> On Mon, Oct 7, 2013 at 6:04 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > The following variables and functions are used only in pcie-designware.c,
> > so make them static:
> ...
> > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> > index c10e9ac..900e875 100644
> > --- a/drivers/pci/host/pcie-designware.c
> > +++ b/drivers/pci/host/pcie-designware.c
> > @@ -64,7 +64,7 @@
> >
> > static struct hw_pci dw_pci;
> >
> > -unsigned long global_io_offset;
> > +static unsigned long global_io_offset;
>
> While you're looking at this, I think "cfg_read()" and "cfg_write()"
> are too generic to be global symbols. I don't know if it would make
> sense to rename them "dw_cfg_read()", pass around pointers in a
> structure or what.
In fact cfg_read, cfg_write & sys_to_pcie should go to common library,
as you will find similar function in other files too.
Regards
Pratyush
>
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-08 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:04 [PATCH] PCI: designware: Make dw_pcie_rd_own_conf(), etc., static Bjorn Helgaas
2013-10-08 0:07 ` Bjorn Helgaas
2013-10-08 6:06 ` Pratyush Anand [this message]
2013-10-09 1:33 ` Jingoo Han
2013-10-09 9:49 ` Thomas Petazzoni
2013-10-09 7:50 ` Jingoo Han
2013-10-09 15:00 ` Bjorn Helgaas
2013-10-09 15:19 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008060643.GA13048@pratyush-vbox \
--to=pratyush.anand@st.com \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.