From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung.kim@lge.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/3] perf stat: Don't require a workload when using system wide or CPU options
Date: Tue, 8 Oct 2013 09:39:28 -0300 [thread overview]
Message-ID: <20131008123928.GA4018@ghostprotocols.net> (raw)
In-Reply-To: <52497F3C.9070908@gmail.com>
Em Mon, Sep 30, 2013 at 07:40:12AM -0600, David Ahern escreveu:
> On 9/30/13 2:47 AM, Namhyung Kim wrote:
> >>@@ -1517,8 +1517,10 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
> >> } else if (big_num_opt == 0) /* User passed --no-big-num */
> >> big_num = false;
> >>
> >>- if (!argc && !perf_target__has_task(&target))
> >>+ if (!argc && !perf_target__has_task(&target) &&
> >>+ !perf_target__has_cpu(&target))
> >
> >You can use perf_target__none() for this.
>
> Indeed. Updated patch attached.
Cool patch, applying to acme/perf/core.
While trying it noticed this, that should also be fixed
eventually:
[root@zoo ~]# perf stat -c C 0
C: No such file or directory
Performance counter stats for 'C 0':
<not counted> task-clock
<not counted> context-switches
<not counted> cpu-migrations
<SNIP>
- Arnaldo
next prev parent reply other threads:[~2013-10-08 12:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 20:27 [PATCH 0/3] perf stat cleanups David Ahern
2013-09-28 20:27 ` [PATCH 1/3] perf stat: Fix misleading message when specifying cpu list or system wide David Ahern
2013-10-15 5:29 ` [tip:perf/core] " tip-bot for David Ahern
2013-09-28 20:27 ` [PATCH 2/3] perf stat: Don't require a workload when using system wide or CPU options David Ahern
2013-09-30 8:47 ` Namhyung Kim
2013-09-30 13:40 ` David Ahern
2013-10-08 12:39 ` Arnaldo Carvalho de Melo [this message]
2013-10-08 12:51 ` Ingo Molnar
2013-10-08 13:27 ` Arnaldo Carvalho de Melo
2013-10-08 19:24 ` Ingo Molnar
2013-10-08 13:25 ` David Ahern
2013-10-08 13:33 ` Arnaldo Carvalho de Melo
2013-10-08 13:42 ` David Ahern
2013-10-15 5:30 ` [tip:perf/core] perf stat: Don' t " tip-bot for David Ahern
2013-09-28 20:28 ` [PATCH 3/3] perf stat: Add units to nanosec-based counters David Ahern
2013-10-15 5:30 ` [tip:perf/core] " tip-bot for David Ahern
2013-10-08 1:44 ` [PATCH 0/3] perf stat cleanups David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008123928.GA4018@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.