From: Al Viro <viro@ZenIV.linux.org.uk>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
vgupta@synopsys.com, catalin.marinas@arm.com,
will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no,
vapier@gentoo.org, msalter@redhat.com, a-jacquiot@ti.com,
starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com,
takata@linux-m32r.org, geert@linux-m68k.org,
james.hogan@imgtec.com, monstr@monstr.eu,
yasutake.koichi@jp.panasonic.com, ralf@linux-mips.org,
jonas@southpole.se, jejb@parisc-linux.org, deller@gmx.de,
benh@kernel.crashing.org, paulus@samba.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
liqin.linux@gmail.com, lennox.wu@gmail.com, lethal@linux-sh.org,
cmetcalf@tilera.com, gxt@mprc.pku.edu.cn,
linux-xtensa@linux-xtensa.org, akpm@linux-foundation.org,
oleg@redhat.com, tj@kernel.org
Subject: Re: [PATCH 28/29] tracehook_signal_handler: Remove sig, info, ka and regs
Date: Tue, 8 Oct 2013 16:45:20 +0100 [thread overview]
Message-ID: <20131008154520.GD13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1381232179-4385-4-git-send-email-richard@nod.at>
On Tue, Oct 08, 2013 at 01:36:18PM +0200, Richard Weinberger wrote:
> These parameters are nowhere used, so we can remove them.
I'm not sure it's a good idea... OTOH, it probably has no business in
tracehook.h anymore - it's only called from signal_delivered(), so if
we decide to insert some ptrace-related work, we can bloody well do it
there these days. It used to be called all over the place in arch/*,
which made a centralized definition (and getting all potentially relevant
data to it) a lot more important. So I'd probably suggest killing that
function off completely - signal_delivered() acts as such centralized
location these days.
next prev parent reply other threads:[~2013-10-08 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 11:36 [PATCH 26/29] xtensa: Use get_signal() signal_setup_done() Richard Weinberger
2013-10-08 11:36 ` Richard Weinberger
2013-10-08 11:36 ` [PATCH 27/29] get_signal_to_deliver: remove regs and cookie args Richard Weinberger
2013-10-08 15:52 ` Christoph Hellwig
2013-10-08 16:00 ` Richard Weinberger
2013-10-08 11:36 ` [PATCH 28/29] tracehook_signal_handler: Remove sig, info, ka and regs Richard Weinberger
2013-10-08 15:45 ` Al Viro [this message]
2013-10-08 16:00 ` Richard Weinberger
2013-10-08 11:36 ` [PATCH 29/29] Clean up signal_delivered() Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008154520.GD13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a-jacquiot@ti.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@tilera.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=heiko.carstens@de.ibm.com \
--cc=hskinnemoen@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=jonas@southpole.se \
--cc=lennox.wu@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=liqin.linux@gmail.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=rkuo@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vapier@gentoo.org \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.