From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume =?iso-8859-1?Q?CL=C9MENT?= Subject: Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers Date: Tue, 8 Oct 2013 22:31:53 +0200 Message-ID: <20131008203148.GA1902@thor.baobob.org> References: <1375897287-8787-1-git-send-email-robdclark@gmail.com> <1375897287-8787-8-git-send-email-robdclark@gmail.com> <20131008195754.GA2010@thor.baobob.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from slow1-d.mail.gandi.net (slow1-d.mail.gandi.net [217.70.178.86]) by gabe.freedesktop.org (Postfix) with ESMTP id EFF60E715D for ; Tue, 8 Oct 2013 13:43:41 -0700 (PDT) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by slow1-d.mail.gandi.net (Postfix) with ESMTP id A7BC347B75E for ; Tue, 8 Oct 2013 22:22:54 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20131008195754.GA2010@thor.baobob.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org > This is quite late to report, but I've just begun testing 3.12, and this > patch makes my screen garbled when using the modesetting xorg driver. > Alright, after trying to notice what was different between the old and new code, I've found the culprit : - gt->npage = pages; There is no equivalent of this line with the new code. This must mess things up. By writing: gt->npage = gt->gem.size / PAGE_SIZE; after: gt->npage = pages; I don't experience the problem anymore. If this looks good to you, I'll create a patch for this. Thanks, - Guillaume