Re: [[PATCH v2] [CIFS] Allow setting per-file compression via SMB2 and SMB3

[David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>]

Hi Steve,

On Tue, 8 Oct 2013 15:41:17 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> +			/* Currently only flag we can set is compressed flag */
> +			if ((ExtAttrBits & FS_COMPR_FL) == 0)
> +				break;
> +
> +			/* Try to set compress flag */
> +			if (tcon->ses->server->ops->set_compression) {
> +				rc = tcon->ses->server->ops->set_compression(
> +							xid, tcon, pSMBFile);
> +				cifs_dbg(FYI, "set compress flag rc %d\n", rc);
>  			}

Is the FileFsAttributeInformation known at this stage? If so, you may
wish to check for the FILE_FILE_COMPRESSION capability, and avoid the
request dispatch if absent.

IIRC, Explorer hides the compression check-checkbox if the capability
is missing.