From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
rjw@rjwysocki.net, Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Rob Landley <rob@landley.net>,
linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] gpiolib / ACPI: convert to gpiod interfaces
Date: Wed, 9 Oct 2013 11:01:09 +0300 [thread overview]
Message-ID: <20131009080109.GT3521@intel.com> (raw)
In-Reply-To: <CAAVeFuJLyqHO+uNm-ehLm4QQU-ZyxsZ0KUG4uYSLvBtbvGQeeQ@mail.gmail.com>
On Tue, Oct 08, 2013 at 09:26:14AM -0700, Alexandre Courbot wrote:
> On Tue, Oct 8, 2013 at 3:36 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Tue, Oct 08, 2013 at 11:45:08AM +0300, Mika Westerberg wrote:
> >> > I also wonder whether you could also avoid exporting acpi_get_gpiod*
> >> > (which allow GPIO consumers to shortcut gpiolib) by implementing
> >> > acpi_get_gpio* into the C file (maybe even using gpiod_get()). I see a
> >> > "char *path" parameter though, so maybe that would not be possible at
> >> > the moment.
> >>
> >> Good point, I'll check if we can do that.
> >
> > Looks like we can get rid of acpi_get_gpio() and acpi_get_gpiod() as there
> > are no users for those outside gpiolib-acpi. I'm going to do that in the
> > next revision.
>
> That's good news. If you can make it such that ACPI GPIO consumers
> don't need to include acpi_gpio.h anymore, then this would make my
> day. :)
We can get rid of the whole apci_gpio.h eventually. But before doing that I
would like to have something that supports both the ACPI way and gpiod way
in v3.13 if possible.
Once we have gpiod_get_index() in mainline, we can convert the existing
user to it and drop acpi_gpio.h completely.
next prev parent reply other threads:[~2013-10-09 8:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 14:58 [PATCH 0/5] gpiolib: convert ACPI GPIO helpers to gpiod_ interfaces Mika Westerberg
2013-10-01 14:58 ` [PATCH 1/5] gpiolib / ACPI: move acpi_gpiochip_free_interrupts next to the request function Mika Westerberg
2013-10-11 10:52 ` Linus Walleij
2013-10-01 14:58 ` [PATCH 2/5] gpiolib / ACPI: convert to gpiod interfaces Mika Westerberg
2013-10-08 4:54 ` Alexandre Courbot
2013-10-08 8:45 ` Mika Westerberg
2013-10-08 8:45 ` Mika Westerberg
2013-10-08 10:36 ` Mika Westerberg
2013-10-08 16:26 ` Alexandre Courbot
2013-10-09 8:01 ` Mika Westerberg [this message]
2013-10-08 16:24 ` Alexandre Courbot
2013-10-08 16:24 ` Alexandre Courbot
2013-10-09 7:58 ` Mika Westerberg
2013-10-09 7:58 ` Mika Westerberg
2013-10-09 16:36 ` Alexandre Courbot
2013-10-09 16:36 ` Alexandre Courbot
2013-10-01 14:58 ` [PATCH 3/5] gpiolib / ACPI: add ACPI support for gpiod_get_index() Mika Westerberg
2013-10-01 14:58 ` [PATCH 4/5] gpiolib / ACPI: allow passing GPIOF_ACTIVE_LOW for GpioInt resources Mika Westerberg
2013-10-01 14:58 ` [PATCH 5/5] gpiolib / ACPI: document the GPIO descriptor based interface Mika Westerberg
2013-10-07 12:18 ` [PATCH 0/5] gpiolib: convert ACPI GPIO helpers to gpiod_ interfaces Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009080109.GT3521@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.