Re: [PATCH] drm/i915: check gem bo size when creating framebuffers

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Oct 09, 2013 at 10:33:08AM +0200, Daniel Vetter wrote:
> It's better to catch such fallout early, and this way we can rely on
> the checking done by the drm core on fb->heigh/width at modeset time.
> 
> If we ever support planar formats on intel we might want to look into
> a common helper to do all this, but for now this is good enough.

I had a helper to do that, and I think I even posted it a few times. But
it didn't take tiling into account, so I didn't feel it was quite good
enough. I think this may be the last one:
http://lists.freedesktop.org/archives/dri-devel/2011-December/017581.html

Your patch doesn't account for tiling either.

> 
> Requested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index f5126b8..3073154 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10069,6 +10069,10 @@ int intel_framebuffer_init(struct drm_device *dev,
>  	if (mode_cmd->offsets[0] != 0)
>  		return -EINVAL;
>  
> +	/* FIXME drm helper for size checks (especially planar formats)? */
> +	if (obj->base.size < mode_cmd->height * mode_cmd->pitches[0])
> +		return -EINVAL;
> +
>  	drm_helper_mode_fill_fb_struct(&intel_fb->base, mode_cmd);
>  	intel_fb->obj = obj;
>  
> -- 
> 1.8.4.rc3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC