All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: acme@ghostprotocols.net, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mike Galbraith <efault@gmx.de>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf record: mmap output file - RFC
Date: Wed, 9 Oct 2013 15:33:31 +0200	[thread overview]
Message-ID: <20131009133331.GC5459@krava.redhat.com> (raw)
In-Reply-To: <1379901959-5285-1-git-send-email-dsahern@gmail.com>

On Sun, Sep 22, 2013 at 08:05:59PM -0600, David Ahern wrote:

SNIP

> +
> +	if (size > remaining) {
> +		memcpy(rec->mmap_addr + rec->mmap_offset, buf, remaining);
> +		rec->bytes_written += remaining;
> +
> +		size -= remaining;
> +		buf  += remaining;
> +
> +		msync(rec->mmap_addr, rec->mmap_size, MS_ASYNC);
> +		munmap(rec->mmap_addr, rec->mmap_size);

do we need msync call if munmap is called right away?


> +		goto do_mmap;

SNIP

> +	if (rec->use_mmap) {
> +		off_t len = rec->bytes_at_mmap_start + rec->bytes_written;
> +
> +		rec->use_mmap = false;
> +		msync(rec->mmap_addr, rec->mmap_size, MS_ASYNC);
> +		munmap(rec->mmap_addr, rec->mmap_size);

ditto

thanks,
jirka

  parent reply	other threads:[~2013-10-09 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23  2:05 [PATCH] perf record: mmap output file - RFC David Ahern
2013-09-26 17:51 ` Jiri Olsa
2013-09-26 18:12   ` David Ahern
2013-09-26 18:23     ` Jiri Olsa
2013-09-26 23:17   ` David Ahern
2013-09-27  6:29     ` Ingo Molnar
2013-09-27  2:24   ` Namhyung Kim
2013-10-09 13:33 ` Jiri Olsa [this message]
2013-10-09 13:46   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131009133331.GC5459@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.