All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: trinity@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 3/3] scripts: arch dependent to get the syscall_list
Date: Wed, 9 Oct 2013 12:41:26 -0400	[thread overview]
Message-ID: <20131009164126.GD2821@redhat.com> (raw)
In-Reply-To: <1381316186-8562-4-git-send-email-anders.roxell@linaro.org>

On Wed, Oct 09, 2013 at 12:56:26PM +0200, Anders Roxell wrote:
 > ARCH may be changed in the enviroment
 > 
 > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
 > ---
 >  scripts/find.sh                           | 10 +++++++++-
 >  scripts/test-all-syscalls-parallel.sh     | 10 +++++++++-
 >  scripts/test-all-syscalls-sequentially.sh | 10 +++++++++-
 >  3 files changed, 27 insertions(+), 3 deletions(-)
 > 
 > diff --git a/scripts/find.sh b/scripts/find.sh
 > index 3f10c58..717beb1 100755
 > --- a/scripts/find.sh
 > +++ b/scripts/find.sh
 > @@ -8,6 +8,14 @@
 >  TRINITY_PATH=${TRINITY_PATH:-.}
 >  TRINITY_TMP=$(mktemp -d /tmp/trinity.XXXXXX)
 >  
 > +if [ $ARCH = "arm" ]; then
 > +    $TRINITY_PATH/trinity -L | grep -v AVOID | \
 > +        awk '{ print $2 }' | sort -u> $TRINITY_TMP/syscall_list
 > +else
 > +    $TRINITY_PATH/trinity -L | grep entrypoint | grep -v AVOID | \
 > +        awk '{ print $4 }' | sort -u> $TRINITY_TMP/syscall_list
 > +fi
 
Ugh. How about we just change the format of the output of -L so it's
more similar on both uniarch and biarch ?

Changing to to be..

on biarch=true:

entrypoint 0 restart_syscall [32-bit] : Enabled AVOID
entrypoint 1 exit [32-bit] : Enabled AVOID
..
entrypoint 312 kcmp [64-bit]
entrypoint 313 finit_module [64-bit]


And then the !biarch case would just lack the *-bit tags, allowing the awk to
pluck out column 2 regardless of arch.

Does that sound better ?

	Dave

  reply	other threads:[~2013-10-09 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 10:56 [PATCH 0/3] script enhancements Anders Roxell
2013-10-09 10:56 ` [PATCH 1/3] scripts: TRINITY_PATH defaults to "." Anders Roxell
2013-10-09 10:56 ` [PATCH 2/3] scripts: change mkdir tmp to mktemp Anders Roxell
2013-10-09 10:56 ` [PATCH 3/3] scripts: arch dependent to get the syscall_list Anders Roxell
2013-10-09 16:41   ` Dave Jones [this message]
2013-10-10  8:45     ` Anders Roxell
2013-10-10  8:41 ` [PATCHv2 3/3] tables.c: change the output format of -L Anders Roxell
2013-10-10 17:20   ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131009164126.GD2821@redhat.com \
    --to=davej@redhat.com \
    --cc=anders.roxell@linaro.org \
    --cc=patches@linaro.org \
    --cc=trinity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.