From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: peterz@infradead.org, fweisbec@gmail.com, dhowells@redhat.com,
edumazet@google.com, gaofeng@cn.fujitsu.com, mingo@kernel.org,
bridge@lists.linux-foundation.org, jmorris@namei.org,
dipankar@in.ibm.com, darren@dvhart.com, rostedt@goodmis.org,
niv@us.ibm.com, mathieu.desnoyers@efficios.com,
kuznet@ms2.inr.ac.ru, tglx@linutronix.de,
johannes@sipsolutions.net, laijs@cn.fujitsu.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-decnet-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kaber@trash.net,
stephen@networkplumber.org, sbw@mit.edu, tgraf@suug.ch,
akpm@linux-foundation.org, fengguang.wu@intel.com,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13
Date: Wed, 9 Oct 2013 15:46:24 -0700 [thread overview]
Message-ID: <20131009224624.GG5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131009221805.GA11709@jtriplet-mobl1>
On Wed, Oct 09, 2013 at 03:18:05PM -0700, Josh Triplett wrote:
> On Wed, Oct 09, 2013 at 02:29:20PM -0700, Paul E. McKenney wrote:
> > Hello!
> >
> > This series features updates to allow sparse to do a better job of
> > statically analyzing RCU usage:
> >
> > 1. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent
> > comiler mischief. Also require that the source pointer be from
> > the kernel address space. Sometimes it can be from the RCU address
> > space, which necessitates the remaining patches in this series.
> > Which, it must be admitted, apply to a very small fraction of
> > the rcu_assign_pointer() invocations in the kernel. This commit
> > courtesy of Josh Triplett.
> >
> > 2-13. Apply rcu_access_pointer() to avoid a number of false positives.
>
> I would suggest moving patch 1 to the end of the series, to avoid
> introducing and subsequently fixing warnings.
That would help with bisectability, will do!
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu,
fengguang.wu@intel.com, stephen@networkplumber.org,
davem@davemloft.net, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, tgraf@suug.ch, gaofeng@cn.fujitsu.com,
linux-decnet-user@lists.sourceforge.net, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
linville@tuxdriver.com, johannes@sipsolutions.net
Subject: Re: [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13
Date: Wed, 9 Oct 2013 15:46:24 -0700 [thread overview]
Message-ID: <20131009224624.GG5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131009221805.GA11709@jtriplet-mobl1>
On Wed, Oct 09, 2013 at 03:18:05PM -0700, Josh Triplett wrote:
> On Wed, Oct 09, 2013 at 02:29:20PM -0700, Paul E. McKenney wrote:
> > Hello!
> >
> > This series features updates to allow sparse to do a better job of
> > statically analyzing RCU usage:
> >
> > 1. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent
> > comiler mischief. Also require that the source pointer be from
> > the kernel address space. Sometimes it can be from the RCU address
> > space, which necessitates the remaining patches in this series.
> > Which, it must be admitted, apply to a very small fraction of
> > the rcu_assign_pointer() invocations in the kernel. This commit
> > courtesy of Josh Triplett.
> >
> > 2-13. Apply rcu_access_pointer() to avoid a number of false positives.
>
> I would suggest moving patch 1 to the end of the series, to avoid
> introducing and subsequently fixing warnings.
That would help with bisectability, will do!
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: peterz@infradead.org, fweisbec@gmail.com, dhowells@redhat.com,
edumazet@google.com, gaofeng@cn.fujitsu.com, mingo@kernel.org,
bridge@lists.linux-foundation.org, jmorris@namei.org,
dipankar@in.ibm.com, darren@dvhart.com, rostedt@goodmis.org,
niv@us.ibm.com, mathieu.desnoyers@efficios.com,
kuznet@ms2.inr.ac.ru, tglx@linutronix.de,
johannes@sipsolutions.net, laijs@cn.fujitsu.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-decnet-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kaber@trash.net,
stephen@networkplumber.org, sbw@mit.edu, tgraf@suug.ch,
akpm@linux-foundation.org, fengguang.wu@intel.com,
davem@davemloft.net
Subject: Re: [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13
Date: Wed, 9 Oct 2013 15:46:24 -0700 [thread overview]
Message-ID: <20131009224624.GG5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131009221805.GA11709@jtriplet-mobl1>
On Wed, Oct 09, 2013 at 03:18:05PM -0700, Josh Triplett wrote:
> On Wed, Oct 09, 2013 at 02:29:20PM -0700, Paul E. McKenney wrote:
> > Hello!
> >
> > This series features updates to allow sparse to do a better job of
> > statically analyzing RCU usage:
> >
> > 1. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent
> > comiler mischief. Also require that the source pointer be from
> > the kernel address space. Sometimes it can be from the RCU address
> > space, which necessitates the remaining patches in this series.
> > Which, it must be admitted, apply to a very small fraction of
> > the rcu_assign_pointer() invocations in the kernel. This commit
> > courtesy of Josh Triplett.
> >
> > 2-13. Apply rcu_access_pointer() to avoid a number of false positives.
>
> I would suggest moving patch 1 to the end of the series, to avoid
> introducing and subsequently fixing warnings.
That would help with bisectability, will do!
Thanx, Paul
next prev parent reply other threads:[~2013-10-09 22:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:29 [Bridge] [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13 Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 01/13] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 02/13] notifiers: Apply rcu_access_pointer() to avoid sparse false positive Paul E. McKenney
2013-10-09 21:29 ` [Bridge] [PATCH v2 tip/core/rcu 03/13] bridge: " Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` [Bridge] [PATCH v2 tip/core/rcu 04/13] wireless: " Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 05/13] decnet: " Paul E. McKenney
2013-10-09 22:28 ` Josh Triplett
2013-10-09 22:46 ` Paul E. McKenney
2013-10-09 22:57 ` Josh Triplett
2013-10-09 23:57 ` Paul E. McKenney
2013-10-09 22:58 ` Dhaval Giani
2013-10-09 23:54 ` Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 06/13] ipv4/ip_socketglue: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: " Paul E. McKenney
2013-10-09 21:42 ` Eric Dumazet
2013-10-09 21:57 ` Paul E. McKenney
2013-10-09 22:10 ` Eric Dumazet
2013-10-09 22:36 ` Paul E. McKenney
2013-10-09 22:51 ` Eric Dumazet
2013-10-09 22:56 ` Josh Triplett
2013-10-09 23:17 ` Eric Dumazet
2013-10-09 23:40 ` Josh Triplett
2013-10-10 0:12 ` Eric Dumazet
2013-10-10 0:28 ` Paul E. McKenney
2013-10-10 2:04 ` Hannes Frederic Sowa
2013-10-10 19:05 ` Paul E. McKenney
2013-10-12 2:25 ` Hannes Frederic Sowa
2013-10-12 7:53 ` Paul E. McKenney
2013-10-12 16:43 ` Hannes Frederic Sowa
2013-10-12 17:37 ` Hannes Frederic Sowa
2013-10-12 19:42 ` Mathieu Desnoyers
2013-10-13 11:14 ` Paul E. McKenney
2013-10-13 20:11 ` Hannes Frederic Sowa
2013-10-11 0:20 ` Josh Triplett
2013-10-11 13:25 ` Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 08/13] ipv6/ip6_gre: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 09/13] ipv6/sit: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 10/13] mac80211: " Paul E. McKenney
2013-10-09 21:29 ` [Bridge] [PATCH v2 tip/core/rcu 11/13] bridge/br_mdb: " Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` [Bridge] [PATCH v2 tip/core/rcu 12/13] bonding/bond_main: " Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 13/13] bonding/bond_alb.c: " Paul E. McKenney
2013-10-09 22:26 ` [PATCH v2 tip/core/rcu 01/13] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Josh Triplett
2013-10-09 22:18 ` [Bridge] [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13 Josh Triplett
2013-10-09 22:18 ` Josh Triplett
2013-10-09 22:46 ` Paul E. McKenney [this message]
2013-10-09 22:46 ` Paul E. McKenney
2013-10-09 22:46 ` Paul E. McKenney
2013-10-09 22:23 ` [Bridge] " Josh Triplett
2013-10-09 22:23 ` Josh Triplett
2013-10-09 22:30 ` [Bridge] " Josh Triplett
2013-10-09 22:30 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009224624.GG5790@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=darren@dvhart.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jmorris@namei.org \
--cc=johannes@sipsolutions.net \
--cc=josh@joshtriplett.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=laijs@cn.fujitsu.com \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.