From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
Date: Thu, 10 Oct 2013 02:39:24 +0200 [thread overview]
Message-ID: <201310100239.24877.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ2F3UFmKSPTAHNAiLPKAqrZkHpGu-iD8KrEbOGV0XNk_g@mail.gmail.com>
Dear Simon Glass,
> +Joe (net maintainer)
> +Marek (USB)
>
> Hi Suriyan,
>
> On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami <suriyan.r@gmail.com>wrote:
> > Add LED activity for SMSX95XX USB Ether driver.
> >
> > Signed-off-by: ?Suriyan Ramasami" <suriyan.r@gmail.com>
> > ---
> >
> > drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++
> > 1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> > index 15fd9a9..7bf0a34 100644
> > --- a/drivers/usb/eth/smsc95xx.c
> > +++ b/drivers/usb/eth/smsc95xx.c
> > @@ -14,6 +14,12 @@
> >
> > /* SMSC LAN95xx based USB 2.0 Ethernet Devices */
> >
> > +/* LED defines */
> > +#define LED_GPIO_CFG (0x24)
> > +#define LED_GPIO_CFG_SPD_LED (0x01000000)
> > +#define LED_GPIO_CFG_LNK_LED (0x00100000)
> > +#define LED_GPIO_CFG_FDX_LED (0x00010000)
> > +
> >
> > /* Tx command words */
> > #define TX_CMD_A_FIRST_SEG_ 0x00002000
> > #define TX_CMD_A_LAST_SEG_ 0x00001000
> >
> > @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth,
> > bd_t *bd)
> >
> > return ret;
> >
> > debug("ID_REV = 0x%08x\n", read_buf);
> >
> > + /* Configure GPIO pins as LED outputs */
> > + write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
> > + LED_GPIO_CFG_FDX_LED;
> > + ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
> > + if (ret < 0)
> > + return ret;
> > + debug("LED_GPIO_CFG set\n");
> > +
>
> Seems good.
>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-10 0:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 3:30 [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver Suriyan Ramasami
2013-10-08 14:37 ` Simon Glass
2013-10-10 0:39 ` Marek Vasut [this message]
2013-10-10 0:40 ` Joe Hershberger
2013-10-10 0:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310100239.24877.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.