All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dong Zhu <bluezhudong@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] timer stats: reset entries when disable the timer usage statistics
Date: Thu, 10 Oct 2013 06:35:19 +0200	[thread overview]
Message-ID: <20131010043519.GB22519@gmail.com> (raw)
In-Reply-To: <20131010025947.GD2139@zhudong.nay.redhat.com>


* Dong Zhu <bluezhudong@gmail.com> wrote:

> From f41628c61d8a9172677ba33a55b61e37ce28f7a6 Mon Sep 17 00:00:00 2001
> From: Dong Zhu <bluezhudong@gmail.com> 
> Date: Thu, 10 Oct 2013 10:38:13 +0800
> 
> When we stop timer statistics collection (via echo 0 > 
> /proc/timers_stats), the statistics data is still exported as if it were 
> correct, which can cause applicaitons to misuse the statistics.

What misuse do you mean?

> This patch resets the statistics when we stop collecting them, to avoid 
> this problem.

Well, this loses the handy 'snapshot' property of /proc/timer_stats. 
Before this change one could do:

	echo 1 > /proc/timers_stats
	sleep 60 # run system workload
	echo 0 > /proc/timers_stats

and examine the 1-minute collection result without it changing. Your 
change, if I understand it correctly, zeroes it all out.

Instead of this change I'd suggest adding a 'status' line, with two 
outputs:

	Status: collection active

	Status: collection disabled

Thanks,

	Ingo

  parent reply	other threads:[~2013-10-10  4:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10  2:59 [PATCH RESEND] timer stats: reset entries when disable the timer usage statistics Dong Zhu
2013-10-10  4:04 ` John Stultz
2013-10-10  4:35 ` Ingo Molnar [this message]
2013-10-10  4:48   ` John Stultz
2013-10-10  6:14   ` [PATCH v2] timer stats: add a 'status' line to " Dong Zhu
2013-10-10  6:16     ` Ingo Molnar
2013-10-10  6:55       ` [PATCH v0.3] " Dong Zhu
2013-10-10  7:26         ` Ingo Molnar
2013-10-10  7:56           ` [PATCH v4] " Dong Zhu
2013-10-10 11:25             ` [tip:timers/core] timer stats: Add a 'Collection: active/inactive ' " tip-bot for Dong Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010043519.GB22519@gmail.com \
    --to=mingo@kernel.org \
    --cc=bluezhudong@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.