All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Picco <bpicco@meloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 0/9] sparc64: Support 47-bit physical addresses.
Date: Thu, 10 Oct 2013 14:19:06 +0000	[thread overview]
Message-ID: <20131010141906.GP29427@zareason> (raw)
In-Reply-To: <20130930.123130.354302574443157859.davem@davemloft.net>

David Miller wrote:	[Wed Oct 09 2013, 04:03:09PM EDT]
> From: Bob Picco <bpicco@meloft.net>
> Date: Fri, 4 Oct 2013 11:45:55 -0400
> 
> > The issue appears to be corruption.
> 
> I think I know what the problem is.
> 
> In set_pmd_at() we need to flush two 4MB pages.
> 
> I'll play around with your test case and a potential fix, thanks.
I believe you need this too. Otherwise the wrong tsb is computed.

 arch/sparc/mm/init_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index 4d0c99b..807e108 100644
--- a/arch/sparc/mm/init_64.c
+++ b/arch/sparc/mm/init_64.c
@@ -2722,7 +2722,7 @@ void update_mmu_cache_pmd(struct vm_area_struct *vma, unsigned long addr,
 	spin_lock_irqsave(&mm->context.lock, flags);
 
 	if (mm->context.tsb_block[MM_TSB_HUGE].tsb != NULL)
-		__update_mmu_tsb_insert(mm, MM_TSB_HUGE, HPAGE_SHIFT,
+		__update_mmu_tsb_insert(mm, MM_TSB_HUGE, REAL_HPAGE_SHIFT,
 					addr, pte);
 
 	spin_unlock_irqrestore(&mm->context.lock, flags);

  parent reply	other threads:[~2013-10-10 14:19 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 16:31 [PATCH v2 0/9] sparc64: Support 47-bit physical addresses David Miller
2013-09-30 20:14 ` Gurudas Pai
2013-09-30 23:07 ` David Miller
2013-09-30 23:47 ` Gurudas Pai
2013-09-30 23:51 ` David Miller
2013-10-01  0:42 ` Gurudas Pai
2013-10-01 20:11 ` David Miller
2013-10-01 23:08 ` Gurudas Pai
2013-10-02  1:20 ` Gurudas Pai
2013-10-02  5:11 ` David Miller
2013-10-02 18:14 ` David Miller
2013-10-02 18:25 ` David Miller
2013-10-02 19:38 ` Gurudas Pai
2013-10-02 20:17 ` David Miller
2013-10-02 21:02 ` Gurudas Pai
2013-10-02 21:18 ` David Miller
2013-10-04  2:07 ` Gurudas Pai
2013-10-04  2:16 ` Gurudas Pai
2013-10-04 15:45 ` Bob Picco
2013-10-04 16:24 ` Bob Picco
2013-10-04 18:00 ` David Miller
2013-10-07 16:07 ` Bob Picco
2013-10-07 16:08 ` David Miller
2013-10-08 13:42 ` Bob Picco
2013-10-09 19:18 ` David Miller
2013-10-09 20:03 ` David Miller
2013-10-10 14:19 ` Bob Picco [this message]
2013-10-11 21:26 ` Gurudas Pai
2013-10-11 21:54 ` David Miller
2013-10-12  2:05 ` Gurudas Pai
2013-10-12  5:06 ` David Miller
2013-10-23  1:18 ` Gurudas Pai
2013-10-23  5:28 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010141906.GP29427@zareason \
    --to=bpicco@meloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.