From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: tell the user KMS is required for gen6+
Date: Thu, 10 Oct 2013 17:28:54 +0300 [thread overview]
Message-ID: <20131010142854.GO13047@intel.com> (raw)
In-Reply-To: <1381407937-4470-1-git-send-email-jani.nikula@intel.com>
On Thu, Oct 10, 2013 at 03:25:37PM +0300, Jani Nikula wrote:
> Educate the users why i915 won't load on gen6+ and nomodeset.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61671
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Yes, much better than the agp wtf error people get currently.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_dma.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 0c86c48..9a54241 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1477,8 +1477,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
> info = (struct intel_device_info *) flags;
>
> /* Refuse to load on gen6+ without kms enabled. */
> - if (info->gen >= 6 && !drm_core_check_feature(dev, DRIVER_MODESET))
> + if (info->gen >= 6 && !drm_core_check_feature(dev, DRIVER_MODESET)) {
> + DRM_INFO("Your hardware requires kernel modesetting (KMS)\n");
> + DRM_INFO("See CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset parameters\n");
> return -ENODEV;
> + }
>
> dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL);
> if (dev_priv == NULL)
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-10-10 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 12:25 [PATCH] drm/i915: tell the user KMS is required for gen6+ Jani Nikula
2013-10-10 14:28 ` Ville Syrjälä [this message]
2013-10-10 17:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010142854.GO13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.