All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tejun Heo <tj@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] sysfs/bin: Fix size handling overflow for bin_attribute
Date: Thu, 10 Oct 2013 10:38:47 -0700	[thread overview]
Message-ID: <20131010173847.GD13759@kroah.com> (raw)
In-Reply-To: <1381388635.4330.37.camel@pasglop>

On Thu, Oct 10, 2013 at 06:03:55PM +1100, Benjamin Herrenschmidt wrote:
> While looking at the code, I noticed that bin_attribute read() and write()
> ops copy the inode size into an int for futher comparisons.
> 
> Some bin_attributes can be fairly large. For example, pci creates some for
> BARs set to the BAR size and giant BARs are around the corner, so this is
> going to break something somewhere eventually.
> 
> Let's use the right type.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

This file (fs/sysfs/bin.c) is no longer in linux-next as Tejun merged it
with the other file handling code in sysfs, to remove a bunch of
duplicated logic.

So, could you look at linux-next and see if this is still an issue there
or not?

thanks,

greg k-h

  reply	other threads:[~2013-10-10 17:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10  4:19 sysfs for my chips Benjamin Herrenschmidt
2013-10-10  7:03 ` [PATCH] sysfs/bin: Fix size handling overflow for bin_attribute Benjamin Herrenschmidt
2013-10-10 17:38   ` Greg KH [this message]
2013-10-10 17:40     ` Greg KH
2013-10-10 20:02       ` Benjamin Herrenschmidt
2013-10-10 17:44 ` sysfs for my chips Greg KH
2013-10-10 20:01   ` Benjamin Herrenschmidt
2013-10-10 20:26     ` Geert Uytterhoeven
2013-10-10 21:30       ` Benjamin Herrenschmidt
2013-10-11  6:52         ` Geert Uytterhoeven
2013-10-11  9:06           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010173847.GD13759@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.