From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Anton Arapov <anton@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] UPROBES: Remove useless __weak attribute
Date: Fri, 11 Oct 2013 06:21:28 +0530 [thread overview]
Message-ID: <20131011005128.GA2199@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131009120809.GN1615@linux-mips.org>
* Ralf Baechle <ralf@linux-mips.org> [2013-10-09 14:08:09]:
> <linux/uprobes.h> declares arch_uprobe_skip_sstep() as a weak function.
> But as there is no definition of generic version so when trying to build
> uprobes for an architecture that doesn't yet have a arch_uprobe_skip_sstep()
> implementation, the vmlinux will try to call arch_uprobe_skip_sstep()
> somehwere in Stupidhistan leading to a system crash. We rather want a
> proper link error so remove arch_uprobe_skip_sstep().
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Will be nice to have another arch(mips) support for uprobes.
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2013-10-11 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 12:08 [PATCH] UPROBES: Remove useless __weak attribute Ralf Baechle
2013-10-10 11:43 ` Oleg Nesterov
2013-10-11 0:51 ` Srikar Dronamraju [this message]
2013-10-11 12:24 ` Ralf Baechle
2013-10-11 22:06 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011005128.GA2199@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=oleg@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.