All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
	kernel-br@googlegroups.com
Subject: Re: [PATCH] dma: edma.c: remove edma_desc leakage
Date: Fri, 11 Oct 2013 07:32:17 +0530	[thread overview]
Message-ID: <20131011020216.GE2954@intel.com> (raw)
In-Reply-To: <1381184398-11307-1-git-send-email-geyslan@gmail.com>

On Mon, Oct 07, 2013 at 07:19:58PM -0300, Geyslan G. Bem wrote:
> Free memory allocated to edma_desc when failing to allocate slot.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Applied thanks

~Vinod
> ---
>  drivers/dma/edma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index ff50ff4..3aab605 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -306,6 +306,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
>  						EDMA_SLOT_ANY);
>  			if (echan->slot[i] < 0) {
>  				dev_err(dev, "Failed to allocate slot\n");
> +				kfree(edesc);
>  				return NULL;
>  			}
>  		}
> -- 
> 1.8.4
> 

-- 

      reply	other threads:[~2013-10-11  2:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07 22:19 [PATCH] dma: edma.c: remove edma_desc leakage Geyslan G. Bem
2013-10-11  2:02 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011020216.GE2954@intel.com \
    --to=vinod.koul@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=geyslan@gmail.com \
    --cc=kernel-br@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.