From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Anand Raj Manickam <anandrm@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables-nftables nft: Removes if_nametoindex ,NFT_META_OIF for outiface
Date: Fri, 11 Oct 2013 11:50:12 +0200 [thread overview]
Message-ID: <20131011095012.GA4787@localhost> (raw)
In-Reply-To: <CAEyr1FSUeGcw_DXBCP7xm0D9D9eFzM98Dv-Mwv0jfyTwaYo--w@mail.gmail.com>
On Fri, Oct 11, 2013 at 03:05:05PM +0530, Anand Raj Manickam wrote:
> On Fri, Oct 11, 2013 at 1:45 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Fri, Oct 11, 2013 at 11:34:04AM +0530, Anand Raj Manickam wrote:
> >> This patch fixes the issue where , the Rules are added for non
> >> existent interface and unable to delete.
> >> eg xtables -t nat -I POSTROUTING -o eth10.10 -j MASQUERADE , allows
> >> you to add the rule , where eth10.10 interface is not created.
> >> But will not allow to delete as the label maps to * by if_nametoindex().
> >
> > This patch doesn't apply:
> >
> > patch -p1 < /tmp/anand.patch
> > patching file iptables/nft-shared.c
> > patch: **** malformed patch at line 6: *iface, int invflags)
> >
> > Please, no need to split things in that many chunks per file. One
> > single patch file to address one thing is just fine, the repository
> > has to remain in consistent state between patches.
> >
> > Thanks.
>
> Merged all into a single patch.
I still think this still breaks -i eth+ matching, as there was special
handling for that case.
next prev parent reply other threads:[~2013-10-11 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 6:04 [PATCH] iptables-nftables nft: Removes if_nametoindex ,NFT_META_OIF for outiface Anand Raj Manickam
2013-10-11 8:15 ` Pablo Neira Ayuso
2013-10-11 9:35 ` Anand Raj Manickam
2013-10-11 9:50 ` Pablo Neira Ayuso [this message]
2013-10-11 10:07 ` Anand Raj Manickam
2013-10-11 11:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011095012.GA4787@localhost \
--to=pablo@netfilter.org \
--cc=anandrm@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.