All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler
Date: Fri, 11 Oct 2013 14:09:40 +0300	[thread overview]
Message-ID: <20131011110940.GO3521@intel.com> (raw)
In-Reply-To: <CACRpkda=C3+pkVsVbZAkasxyWGedNsb7oAKTt4ApnJ4Q+k9BCw@mail.gmail.com>

On Fri, Oct 11, 2013 at 12:57:37PM +0200, Linus Walleij wrote:
> On Tue, Oct 1, 2013 at 4:35 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> 
> > Checking LP_INT_STAT is not enough in the interrupt handler because its
> > contents get updated regardless of whether the pin has interrupt enabled or
> > not. This causes the driver to loop forever for GPIOs that are pulled up.
> >
> > Fix this by checking the interrupt enable bit for the pin as well.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Patch applied for fixes with Mathias ACK.

Thanks!

> Should this be tagged for -stable as well?

Yes, please. I think starting from 3.9 when this driver was merged.

      reply	other threads:[~2013-10-11 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 14:35 [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler Mika Westerberg
2013-10-02 11:03 ` Mathias Nyman
2013-10-11 10:57 ` Linus Walleij
2013-10-11 11:09   ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011110940.GO3521@intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.