From: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: make backlight functions take a connector v4
Date: Fri, 11 Oct 2013 15:44:05 -0700 [thread overview]
Message-ID: <20131011154405.645eb07a@jbarnes-desktop> (raw)
In-Reply-To: <1381527996-2567-1-git-send-email-jbarnes@virtuousgeek.org>
On Fri, 11 Oct 2013 14:46:36 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On VLV/BYT, backlight controls a per-pipe, so when adjusting the
> backlight we need to pass the correct info. So make the externally
> visible backlight functions take a connector argument, which can be used
> internally to figure out the pipe backlight to adjust.
>
> v2: make connector pipe lookup check for NULL crtc (Jani)
> fixup connector check in ASLE code (Jani)
> v3: make sure we take the mode config lock around lookups (Daniel)
> v4: fix double unlock in panel_get_brightness (Daniel)
Ok ok you caught me. I didn't test v3... I did test this version but
w/o lockdep and apparently w/o any ASLE events or I would have seen the
sleeping while atomic messages.
Guess we'll have to factor out the ASLE callback into a work queue (I
don't *think* the BIOS will care, we'll have to see).
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-11 22:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 18:31 [PATCH 1/2] drm/i915: make backlight functions take a connector v3 Jesse Barnes
2013-10-11 18:31 ` [PATCH 2/2] drm/i915/vlv: use per-pipe backlight controls v2 Jesse Barnes
2013-10-11 21:31 ` [PATCH 1/2] drm/i915: make backlight functions take a connector v3 Daniel Vetter
2013-10-11 21:34 ` Jesse Barnes
2013-10-11 23:19 ` Jesse Barnes
2013-10-11 23:55 ` Daniel Vetter
2013-10-12 0:06 ` Daniel Vetter
[not found] ` <22791_1381536398_5258928E_22791_19022_1_CAKMK7uGtNCujq7PEoyJzke6w=y2qcsopa4mvSCLsiWtf72z7AA@mail.gmail.com>
2013-10-13 19:54 ` intel-drm-nightly broken on 835GM Thomas Richter
2013-10-14 8:23 ` [PATCH 1/2] drm/i915: make backlight functions take a connector v3 Daniel Vetter
2013-10-11 21:46 ` [PATCH] drm/i915: make backlight functions take a connector v4 Jesse Barnes
2013-10-11 22:44 ` Jesse Barnes [this message]
2013-10-14 18:03 ` [PATCH] drm/i915: make backlight functions take a connector v5 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011154405.645eb07a@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.