All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] weston: add missing toolchain comments
Date: Fri, 11 Oct 2013 23:10:53 +0200	[thread overview]
Message-ID: <20131011211053.GA29458@free.fr> (raw)
In-Reply-To: <1381525213-14034-2-git-send-email-arnout@mind.be>

Arnout, All,

On 2013-10-11 23:00 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/weston/Config.in | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/weston/Config.in b/package/weston/Config.in
> index fd48fb3..ea0e87e 100644
> --- a/package/weston/Config.in
> +++ b/package/weston/Config.in
> @@ -1,5 +1,5 @@
> -comment "weston requires udev"
> -	depends on !BR2_PACKAGE_UDEV
> +comment "weston needs udev and a toolchain w/ threads"
> +	depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS

Doh, I just forgot about this... Thanks! :-)

>  config BR2_PACKAGE_WESTON
>  	bool "weston"
> @@ -30,6 +30,10 @@ if BR2_PACKAGE_WESTON
>  config BR2_PACKAGE_WESTON_HAS_COMPOSITOR
>  	bool
>  
> +comment "RPi compositor needs a toolchain w/ C++, largefile, threads

Missing terminating double-quotes.

> +	depends on BR2_arm
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> +
>  config BR2_PACKAGE_WESTON_RPI
>  	bool "RPi compositor"
>  	depends on BR2_arm                      # rpi-userland

Otherwise:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-10-11 21:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 21:00 [Buildroot] [PATCH 1/3] weston: improve selection of compositor Arnout Vandecappelle
2013-10-11 21:00 ` [Buildroot] [PATCH 2/3] weston: add missing toolchain comments Arnout Vandecappelle
2013-10-11 21:10   ` Yann E. MORIN [this message]
2013-10-11 21:00 ` [Buildroot] [PATCH 3/3] weston: add help text for compositor backends Arnout Vandecappelle
2013-10-11 21:17   ` Yann E. MORIN
2013-10-11 21:23 ` [Buildroot] [PATCH 1/3] weston: improve selection of compositor Yann E. MORIN
2013-10-11 22:39 ` Yann E. MORIN
2013-10-12 10:58   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011211053.GA29458@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.